Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751767AbdGYSPj (ORCPT ); Tue, 25 Jul 2017 14:15:39 -0400 Received: from mail-yw0-f170.google.com ([209.85.161.170]:34329 "EHLO mail-yw0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750980AbdGYSPh (ORCPT ); Tue, 25 Jul 2017 14:15:37 -0400 Date: Tue, 25 Jul 2017 14:15:35 -0400 From: Josef Bacik To: Dennis Zhou Cc: Tejun Heo , Christoph Lameter , Josef Bacik , linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel-team@fb.com, Dennis Zhou Subject: Re: [PATCH v2 07/23] percpu: setup_first_chunk rename schunk/dchunk to chunk Message-ID: <20170725181535.GG18880@destiny> References: <20170724230220.21774-1-dennisz@fb.com> <20170724230220.21774-8-dennisz@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170724230220.21774-8-dennisz@fb.com> User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 525 Lines: 15 On Mon, Jul 24, 2017 at 07:02:04PM -0400, Dennis Zhou wrote: > From: "Dennis Zhou (Facebook)" > > There is no need to have the static chunk and dynamic chunk be named > separately as the allocations are sequential. This preemptively solves > the misnomer problem with the base_addrs being moved up in the following > patch. It also removes a ternary operation deciding the first chunk. > > Signed-off-by: Dennis Zhou Reviewed-by: Josef Bacik Thanks, Josef