Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754065AbdGYTZK (ORCPT ); Tue, 25 Jul 2017 15:25:10 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:36550 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754046AbdGYTZH (ORCPT ); Tue, 25 Jul 2017 15:25:07 -0400 From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dan Carpenter , Amir Goldstein , Miklos Szeredi Subject: [PATCH 4.12 113/196] ovl: fix random return value on mount Date: Tue, 25 Jul 2017 12:21:52 -0700 Message-Id: <20170725192051.910908681@linuxfoundation.org> X-Mailer: git-send-email 2.13.3 In-Reply-To: <20170725192046.422343510@linuxfoundation.org> References: <20170725192046.422343510@linuxfoundation.org> User-Agent: quilt/0.65 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1012 Lines: 34 4.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: Amir Goldstein commit 8fc646b44385ff0a9853f6590497e43049eeb311 upstream. On failure to prepare_creds(), mount fails with a random return value, as err was last set to an integer cast of a valid lower mnt pointer or set to 0 if inodes index feature is enabled. Reported-by: Dan Carpenter Fixes: 3fe6e52f0626 ("ovl: override creds with the ones from ...") Signed-off-by: Amir Goldstein Signed-off-by: Miklos Szeredi Signed-off-by: Greg Kroah-Hartman --- fs/overlayfs/super.c | 1 + 1 file changed, 1 insertion(+) --- a/fs/overlayfs/super.c +++ b/fs/overlayfs/super.c @@ -946,6 +946,7 @@ static int ovl_fill_super(struct super_b else sb->s_d_op = &ovl_dentry_operations; + err = -ENOMEM; ufs->creator_cred = cred = prepare_creds(); if (!cred) goto out_put_lower_mnt;