Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754052AbdGYTn7 (ORCPT ); Tue, 25 Jul 2017 15:43:59 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:59162 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751951AbdGYTn5 (ORCPT ); Tue, 25 Jul 2017 15:43:57 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org A18A56072F Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=nleeder@codeaurora.org Subject: Re: [PATCH] perf: qcom_l2: fix column exclusion check To: Mark Rutland Cc: Will Deacon , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Mark Langsdorf , Mark Salter , Jon Masters , Timur Tabi , Mark Brown , nleeder@codeaurora.org References: <1500931022-21000-1-git-send-email-nleeder@codeaurora.org> <20170725170105.GF12749@leverpostej> From: "Leeder, Neil" Message-ID: <95095f56-7b08-4ed9-f7e5-5d5768a75cc5@codeaurora.org> Date: Tue, 25 Jul 2017 15:43:54 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <20170725170105.GF12749@leverpostej> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1012 Lines: 30 On 7/25/2017 1:01 PM, Mark Rutland wrote: > On Mon, Jul 24, 2017 at 05:17:02PM -0400, Neil Leeder wrote: >> The check for column exclusion did not verify that the event being >> checked was an L2 event, and not a software event. >> Software events should not be checked for column exclusion. >> This resulted in a group with both software and L2 events sometimes >> incorrectly rejecting the L2 event for column exclusion and >> not counting it. >> >> Add a check for PMU type before applying column exclusion logic. >> >> Signed-off-by: Neil Leeder > > This looks correct, so: > > Acked-by: Mark Rutland > > Should this have: > > Fixes: 21bdbb7102edeaeb ("perf: add qcom l2 cache perf events driver") > > ... ? > Thanks. I'll re-post with the Fixes tag. Neil -- Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.