Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753043AbdGYUgy (ORCPT ); Tue, 25 Jul 2017 16:36:54 -0400 Received: from mail.kernel.org ([198.145.29.99]:38510 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752882AbdGYUgw (ORCPT ); Tue, 25 Jul 2017 16:36:52 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8047C21C99 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=robh+dt@kernel.org MIME-Version: 1.0 In-Reply-To: <1493165394-29367-3-git-send-email-frowand.list@gmail.com> References: <1493165394-29367-1-git-send-email-frowand.list@gmail.com> <1493165394-29367-3-git-send-email-frowand.list@gmail.com> From: Rob Herring Date: Tue, 25 Jul 2017 15:36:29 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4 2/2] of: Add unit tests for applying overlays To: Frank Rowand Cc: Stephen Boyd , Michal Marek , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Linux Kbuild mailing list Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 867 Lines: 25 On Tue, Apr 25, 2017 at 7:09 PM, wrote: > From: Frank Rowand > > Existing overlay unit tests examine individual pieces of the overlay > code. The new tests target the entire process of applying an overlay. > > Signed-off-by: Frank Rowand > --- [...] > @@ -1261,6 +1263,8 @@ void __init unflatten_device_tree(void) > > /* Get pointer to "/chosen" and "/aliases" nodes for use everywhere */ > of_alias_scan(early_init_dt_alloc_memory_arch); > + > + unittest_unflatten_overlay_base(); This breaks on systems that don't boot with FDT and call unflatten_device_tree, namely x86 and UML (UML needs a few hacks to work) which was a feature of the unittest. Considering applying overlays on x86 is something we'll want to support, the unittest should support that case. Rob