Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752546AbdGYUyw (ORCPT ); Tue, 25 Jul 2017 16:54:52 -0400 Received: from home.keithp.com ([63.227.221.253]:52422 "EHLO elaine.keithp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751528AbdGYUyu (ORCPT ); Tue, 25 Jul 2017 16:54:50 -0400 From: Keith Packard To: Daniel Vetter Cc: Daniel Vetter , linux-kernel@vger.kernel.org, Dave Airlie , dri-devel@lists.freedesktop.org Subject: Re: [PATCH 1/3] drm: Widen vblank count to 64 bits. Change vblank time precision to ns In-Reply-To: <20170707121640.4oedsdmpwhi4neyj@phenom.ffwll.local> References: <20170705221013.27940-1-keithp@keithp.com> <20170705221013.27940-2-keithp@keithp.com> <20170706071948.pphlrqjcyas3zdfy@phenom.ffwll.local> <86tw2pd314.fsf@keithp.com> <20170707121640.4oedsdmpwhi4neyj@phenom.ffwll.local> Date: Tue, 25 Jul 2017 13:54:46 -0700 Message-ID: <8760egutih.fsf@keithp.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2013 Lines: 53 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Daniel Vetter writes: > I'd drop that part (but keep 64 everywhere else ofc). Yeah, we only ever ask drivers for a delta anyways, so keeping an internal 64-bit value while retaining the 32-bit driver API is easy to manage. >> > Other thought on this, since you bother to change all the types: Afaik >> > both timespec and timeval suffer from the 32bit issues. >>=20 >> I'm not sure what 32bit issues you're concerned about here? We don't >> compare these values, just report them up to user space. > > Year 2038 32bit wrap-around bug. Yes I believe/fear drm will still be > around then :-) A fine point. I've switched to ktime_t, which has additional benefits in making the internal interfaces a bit cleaner with pass-by-value possible in more cases now. I've pushed incremental patches out for all of the suggested changes to my drm-sequence-64 branch. I think I'll send those out as incremental patches and then also send out a squashed version from the original branch point. =2D-=20 =2Dkeith --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEw4O3eCVWE9/bQJ2R2yIaaQAAABEFAll3sBYACgkQ2yIaaQAA ABFt6g/+PoSt3KK/TS8TOYIxhDL7m0iQ7JhTQaoEMnWUhfw4P2CinErNvM7+zHUN EV0epZK5PuK9poCQLRbr7xSi8K4bAd4UMjCq+ohesFsHaLerXKwtNyGc7JN9igGP ixDQ5vQxCGKCXsQlwB9xyE0KK7Fyd8sOxwdHIHwcoQKgYTuMttLVgItYXfZf3pHp Mz7Jmmzq0sMKa8JalamZiYKBPYjRKZGZVma+K0slUIuMtfBNB6aSh6hwYdBXWH9g E5zWABGWjBDoO+YBNUViZD8Y1zuJtmqbqsMg2e0zVQQC7lstsiTEijJE1h2LaLS4 sGaD7JbvVXB3cnyhYVBFY21sbt4PaHqShNQXpC8vzCcAOMw+hkrgfXPomtnbsJNV nzNs2QgnR/sqq2tVjfl/aHDHIPVbM+QRsUqJYAe32gTdYhp21B9V+huqwz7X9JJe Tv6vi2VhWczriRfwWnnRIhBPQ6w6trrk4sVJ/r+tQYYOLMtp1ujNaRngObeU4vtV fyvnB09BGZRyMRv+rSbkaTRF7nlRfDwgsVLjaPcy357LUeg7Xi2KgE/fUX65I2Q9 lI4DwkxXt40erp1NXG8YpOxf4C3c45Ov/nEGZx+FZkQ7dbDxEOpMvEZgvQcDx+4F 7XIoMwCo36l6ZeMeaFEKePPSGAp4roCamwRhuuvpyR5aws61cJ8= =PBK1 -----END PGP SIGNATURE----- --=-=-=--