Date: Wed, 26 Jul 2017 04:57:17 +0200
From: Jonathan =?utf-8?Q?Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>
To: patches@groups.riscv.org
Cc: Olof Johansson <olof@lixom.net>, Arnd Bergmann <arnd@arndb.de>,
        akpm@linux-foundation.org, albert@sifive.com,
        yamada.masahiro@socionext.com, mmarek@suse.com, will.deacon@arm.com,
        peterz@infradead.org, boqun.feng@gmail.com, mingo@redhat.com,
        daniel.lezcano@linaro.org, tglx@linutronix.de, jason@lakedaemon.net,
        marc.zyngier@arm.com, gregkh@linuxfoundation.org, jslaby@suse.com,
        davem@davemloft.net, mchehab@kernel.org, sfr@canb.auug.org.au,
        fweisbec@gmail.com, viro@zeniv.linux.org.uk, mcgrof@kernel.org,
        dledford@redhat.com, bart.vanassche@sandisk.com,
        sstabellini@kernel.org, daniel.vetter@ffwll.ch, mpe@ellerman.id.au,
        msalter@redhat.com, nicolas.dichtel@6wind.com, james.hogan@imgtec.com,
        paul.gortmaker@windriver.com, linux@roeck-us.net,
        heiko.carstens@de.ibm.com, schwidefsky@de.ibm.com,
        linux-kernel@vger.kernel.org, Palmer Dabbelt <palmer@dabbelt.com>
Subject: Re: [patches] [PATCH 17/17] RISC-V: Build Infastructure
Message-ID: <20170726025717.lob7jlrb6ipa6rel@latitude>
References: <20170712013130.14792-1-palmer@dabbelt.com>
 <20170712013130.14792-18-palmer@dabbelt.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
        protocol="application/pgp-signature"; boundary="mvf7kr5nnzqeyzhe"
Content-Disposition: inline
In-Reply-To: <20170712013130.14792-18-palmer@dabbelt.com>
User-Agent: NeoMutt/20170113 (1.7.2)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2325
Lines: 62


--mvf7kr5nnzqeyzhe
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Jul 11, 2017 at 06:31:30PM -0700, Palmer Dabbelt wrote:
> This patch contains all the build infastructure that actually enables
> the RISC-V port.  This includes Makefiles, linker scripts, and Kconfig
> files.  It also contains the only top-level change, which adds RISC-V to
> the list of architectures that need a sed run to produce the ARCH
> variable when building locally.
>=20
> Signed-off-by: Palmer Dabbelt <palmer@dabbelt.com>
> ---
[...]
> +config ISA_C
> +	bool "Emit compressed instructions when building Linux"

As a user, I'd prefer to have slightly more globally-recognisable names
than ISA_<single letter> for RISC-V instruction set architecture
extensions. A quick "git grep -A2 'config ISA'" shows the following
Kconfig symbols:

* ISA, ISA_BUS_API, ISA_DMA_API, ISAPNP:
  Settings related to the historic ISA bus.
* ISA_ARCOMPACT/ISA_ARCV2 (arch/arc),
  ISA_M32R/ISA_M32R2/ISA_DSP_LEVEL2/ISA_DUAL_ISSUE (arch/m32r):
  Instruction set options.

Four out of the six instruction set options have ARC/M32R in the name,
and I think that makes things slightly more readable. Therefore I
humbly propose something longer, and with a hint of RISC-V in the name,
such as ISA_RVC.

(Take this with a grain of salt, perhaps.)


Jonathan Neusch=C3=A4fer

--mvf7kr5nnzqeyzhe
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAABAgAGBQJZeAUEAAoJEAgwRJqO81/bbPsQAIngmXUoDhXTFOMVX7Dxb/Fq
HipNe4MeROQUJTbsEFqBBrcBUOS9o694az00RNV9q45Qlor6kE5kta8EPXmuGZPl
UzMzYxO1HBOp1mM64ui+LNrQ+yvt1aY+Of6llx1swTAh5jgpPaRwBKwUQ1slcxRI
67E34g1hL6L4Lx4zxpLje/10JuYpTI48Sb2x59E1CWoISGARfIimqJVEvyTB/Zqt
8zUW5NB37Uck7YTtZLRl3K661nEjpbIwv5raDW2uzrmrXFpNbemb2dMnJtGms6bl
POqifRih+/wrpZBNcDhcdHPmlglD09mvYays/x8LSBEfOKt/meAHPyNbSfc/yGph
/g3YB3s/C42YHy0eaPyuEAgex6bcNVKrcGPAHltvA0yCxm/GTpm03hzjw+FW5/Fr
rmI6jr/rwMB/FCAyH7vLetdcEdmrrhHXf2/1CBwLMFW0wSpVeTZN55m9o5734oAC
+1xKTf/k6YY+ZFuK/xGOExiDnL7Z1DmxQRavdfXND0Ql3wjFopZJ5XfuH/Wor35X
iHpzkTBjk4drDkX5pHpyOuzUEFEpzhXR6uHeupyaB7r+ylPUzRAy45UzUZlpBKDN
jxK8WCkDcmMMEFFq96G1DYV4VK85BdaY/DgAKchpsTjHAPpw2h018qcXwnSqljpv
tjpn0UjNcc6UlTzWGMye
=JFHq
-----END PGP SIGNATURE-----

--mvf7kr5nnzqeyzhe--