Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751788AbdGZDTh (ORCPT ); Tue, 25 Jul 2017 23:19:37 -0400 Received: from mail-pg0-f67.google.com ([74.125.83.67]:35895 "EHLO mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751720AbdGZDTf (ORCPT ); Tue, 25 Jul 2017 23:19:35 -0400 Date: Wed, 26 Jul 2017 11:19:34 +0800 From: Wei Yang To: Borislav Petkov Cc: Wei Yang , kirill@shutemov.name, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, tj@kernel.org, rientjes@google.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH V3 1/3] x86/numa_emulation: refine the calculation of max_emu_nid and dfl_phys_nid Message-ID: <20170726031934.GA9093@WeideMacBook-Pro.local> Reply-To: Wei Yang References: <20170708013059.29708-1-richard.weiyang@gmail.com> <20170708013059.29708-2-richard.weiyang@gmail.com> <20170718105953.GA9149@nazgul.tnic> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="wac7ysb48OaltWcw" Content-Disposition: inline In-Reply-To: <20170718105953.GA9149@nazgul.tnic> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2344 Lines: 73 --wac7ysb48OaltWcw Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jul 18, 2017 at 01:03:39PM +0200, Borislav Petkov wrote: >On Sat, Jul 08, 2017 at 09:30:57AM +0800, Wei Yang wrote: >> max_emu_nid and dfl_phys_nid is calculated from emu_nid_to_phys[], which= is >> calculated in split_nodes_xxx_interleave(). From the logic in these > >$ git grep split_nodes_xxx_interleave >$ > >> functions, it is assured the emu_nid_to_phys[] has meaningful value if it >> return successfully and ensures dfl_phys_nid will get a valid value. >>=20 >> This patch removes the error branch to check invalid dfl_phys_nid and > >So the check doesn't hurt anyone. > >On the contrary - it is an "assertion" of sorts in otherwise complex >code and actually documents the fact that by then emu_nid_to_phys[] >needs to be setup properly. > >And it is especially useful if someone decides to change that code in >the future, for whatever reason, and gets to hit that check - it'll even >be helpful in that case. > >So I'd vote for keeping that check and not doing anything. > >While we're at it, never say "this patch" in a commit message - that is >tautologically obvious. > Hi, Borislav=20 Thanks for your comment, I will this in my mind. >--=20 >Regards/Gruss, > Boris. > >ECO tip #101: Trim your mails when you reply. >-- --=20 Wei Yang Help you, Help me --wac7ysb48OaltWcw Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJZeApGAAoJEKcLNpZP5cTdZiEP/1zC91/XuRVMeEGIba+ZAVHV PtVW+NfqM5DgS0sef4wYjUcuLCdQ/SLSJ3rDkOzCJIi+TWl+uW+dkv8tshcSK37K Beyh+HgHvPgB7y8nEgRLHKkfgvmOQOT1qWdcr3D3dw+ZWSInwgqtYu0FgS6jvioK 4ayeZ0AROXlhNHqBQWeo+i8RsX0TUIHcK3bhLrDEfvTtVXlgKqzwF5IleF2LSM0T 12udmqhxvhqVvXUakxaEzdsIjkqgijuC+ykKzoh6BRFCyoB3UAm18XiAHbphGS2B VWAIYGkpPU8rM3bGPB5gXzm/Y5VWRX0t8zn4XtFF4xFcd2rf43WBGjZxm5wcDHNH eFwJr9nxLFAcRBFy7MVdTQQovf+k/M2CdMZDlLS+hXbDy2IUz/kgVTaxsSigfFSx NUp2DCpjV+v23Ong/KbWru5KHZhIv0uX/CROtu6C94DGF2B4ueztJybYJPHjDU5u nRa1+Wp1Ai13wvApAQ9fsnu/APQqx/gj/KiWiWSQ6iNOg1HYa5cWy9pHd5N2w3GT fHmqxOeK6POf2Cf2DRrJcB7E5K1axI34JrmZNUkOhpxE0RAshC4nDDhBn4bfht9Q i2u0znIE5dyPvNVFbPID95ouDb4MFmqESpw918Sx+O9CzbhYBDiQJiXzHBz+S33J cfSVc3oEFu5DZdxGA4TZ =M90h -----END PGP SIGNATURE----- --wac7ysb48OaltWcw--