Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751040AbdGZH0g (ORCPT ); Wed, 26 Jul 2017 03:26:36 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:56529 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750772AbdGZH0f (ORCPT ); Wed, 26 Jul 2017 03:26:35 -0400 Date: Wed, 26 Jul 2017 00:26:34 -0700 From: Christoph Hellwig To: Dan Williams Cc: sunqiuyang , linux-fsdevel , Jaegeuk Kim , "linux-nvdimm@lists.01.org" , Linux Kernel Mailing List , linux-f2fs-devel@lists.sourceforge.net Subject: Re: [PATCH v8 1/1] f2fs: dax: implement direct access Message-ID: <20170726072634.GA4684@infradead.org> References: <1500552639-18523-1-git-send-email-sunqiuyang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.8.0 (2017-02-23) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1088 Lines: 20 On Tue, Jul 25, 2017 at 05:15:10PM -0700, Dan Williams wrote: > We're in the process of walking back and potentially deprecating the > use of the dax mount option for xfs and ext4 since dax can have > negative performance implications if page cache memory happens to be > faster than pmem. It should be limited to applications that > specifically want the semantic, not globally enabled for the entire > mount. xfs has went ahead and added the XFS_DIFLAG2_DAX indoe flag for > per-inode enabling of dax. > > I'm wondering if any new filesystem that adds dax support at this > point should do so with inode flags and not a mount option? That tradeoff is not one that the application should make, but one that should depend on the storage medium. To make things worse it might also depend on the type of access. E.g. with certain media it makes a lot of sense to cache writes in the page cache, but generally not reads. I've been spending some time to analyze how that could be done, but I've not made real progress on it. XFS_DIFLAG2_DAX is unfortunately totally unhelpful with that.