Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751497AbdGZH2e (ORCPT ); Wed, 26 Jul 2017 03:28:34 -0400 Received: from wp244.webpack.hosteurope.de ([80.237.133.13]:56632 "EHLO wp244.webpack.hosteurope.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751109AbdGZH2c (ORCPT ); Wed, 26 Jul 2017 03:28:32 -0400 Date: Wed, 26 Jul 2017 09:28:28 +0200 (CEST) From: Marcus Wolf To: Greg Kroah-Hartman , Arnd Bergmann Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org Message-ID: <563430730.43054.1501054109184@ox.hosteurope.de> In-Reply-To: <20170725153825.272975-1-arnd@arndb.de> References: <20170725153825.272975-1-arnd@arndb.de> Subject: Re: [PATCH] staging: pi433: fix Kconfig entry MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Priority: 3 Importance: Medium X-Mailer: Open-Xchange Mailer v7.8.3-Rev29 X-Originating-Client: com.openexchange.ox.gui.dhtml X-bounce-key: webpack.hosteurope.de;marcus.wolf@wolf-entwicklungen.de;1501054112;92c52ab1; X-HE-SMSGID: 1daGk9-0004Rq-9d Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2666 Lines: 64 Reviewed-by: Marcus Wolf This is similar to patch "[PATCH -next] staging: pi433: depends on SPI" of Randy Dunlap > Arnd Bergmann hat am 25. Juli 2017 um 17:38 geschrieben: > > > I ran into a build error with the new pi433 driver and > CONFIG_SPI disabled: > > drivers/staging/pi433/pi433_if.o: In function `pi433_probe.part.6': > pi433_if.c:(.text+0x1657): undefined reference to `spi_write_then_read' > drivers/staging/pi433/pi433_if.o: In function `pi433_probe': > pi433_if.c:(.text+0x1d28): undefined reference to `spi_setup' > drivers/staging/pi433/pi433_if.o: In function `pi433_init': > > I'm adding a Kconfig dependency on CONFIG_SPI here to avoid that, > and since I spot two cosmetic mistakes in the entry, I'm also > fixing the whitespace and remove the redundant 'default n'. > > Fixes: 874bcba65f9a ("staging: pi433: New driver") > Signed-off-by: Arnd Bergmann > --- > drivers/staging/pi433/Kconfig | 24 ++++++++++++------------ > 1 file changed, 12 insertions(+), 12 deletions(-) > > diff --git a/drivers/staging/pi433/Kconfig b/drivers/staging/pi433/Kconfig > index b2716b85d5af..2fd07991c871 100644 > --- a/drivers/staging/pi433/Kconfig > +++ b/drivers/staging/pi433/Kconfig > @@ -1,16 +1,16 @@ > config PI433 > - tristate "Pi433 - a 433MHz radio module for Raspberry Pi" > - default n > - ---help--- > - This option allows you to enable support for the radio module Pi433. > + tristate "Pi433 - a 433MHz radio module for Raspberry Pi" > + depends on SPI > + ---help--- > + This option allows you to enable support for the radio module Pi433. > > - Pi433 is a shield that fits onto the GPIO header of a Raspberry Pi > - or compatible. It extends the Raspberry Pi with the option, to > - send and receive data in the 433MHz ISM band - for example to > - communicate between two systems without using ethernet or bluetooth > - or for control or read sockets, actors, sensors, widely available > - for low price. > + Pi433 is a shield that fits onto the GPIO header of a Raspberry Pi > + or compatible. It extends the Raspberry Pi with the option, to > + send and receive data in the 433MHz ISM band - for example to > + communicate between two systems without using ethernet or bluetooth > + or for control or read sockets, actors, sensors, widely available > + for low price. > > - For details or the option to buy, please visit https://pi433.de/en.html > + For details or the option to buy, please visit https://pi433.de/en.html > > - If in doubt, say N here, but saying yes most probably won't hurt > + If in doubt, say N here, but saying yes most probably won't hurt > -- > 2.9.0 > >