Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751031AbdGZHuG (ORCPT ); Wed, 26 Jul 2017 03:50:06 -0400 Received: from merlin.infradead.org ([205.233.59.134]:44046 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750813AbdGZHuF (ORCPT ); Wed, 26 Jul 2017 03:50:05 -0400 Date: Wed, 26 Jul 2017 09:49:48 +0200 From: Peter Zijlstra To: Pratyush Anand Cc: Will Deacon , mark.rutland@arm.com, linux-arm-kernel@lists.infradead.org, Ingo Molnar , Arnaldo Carvalho de Melo , Alexander Shishkin , huawei.libin@huawei.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH V2 1/4] hw_breakpoint: Add step_needed event attribute Message-ID: <20170726074947.qynkabkdpfmcjj2l@hirez.programming.kicks-ass.net> References: <9d4f76f3a0bffe93a6d5146c9b53ee7b985f22da.1499416107.git.panand@redhat.com> <20170725132737.GC28815@arm.com> <70b51184-dbe0-6d0b-c853-be5b556927f1@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <70b51184-dbe0-6d0b-c853-be5b556927f1@redhat.com> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 428 Lines: 9 On Wed, Jul 26, 2017 at 11:12:03AM +0530, Pratyush Anand wrote: > I too had thought to put it under include/linux/perf_event.h : struct > perf_event. But, see hw_break_module_init() which does not have knowledge of > this structure, and we need to have some way so that none-perf kernel module > implementation can tell that it needs default arch step handler. > > Do you see any alternative? Fix the hw_breakpoint interface?