Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751502AbdGZIYf (ORCPT ); Wed, 26 Jul 2017 04:24:35 -0400 Received: from mail-wr0-f181.google.com ([209.85.128.181]:36798 "EHLO mail-wr0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750907AbdGZIYe (ORCPT ); Wed, 26 Jul 2017 04:24:34 -0400 Date: Wed, 26 Jul 2017 09:24:30 +0100 From: Lee Jones To: Alexander Dahl Cc: linux-arm-kernel@lists.infradead.org, Boris Brezillon , Nicolas Ferre , Alexandre Belloni , linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] memory: atmel-ebi: Fix smc cycle xlate converter Message-ID: <20170726082430.3egpdk7dtqh2uoa5@dell> References: <1500984024-26403-1-git-send-email-ada@thorsis.com> <1500984024-26403-4-git-send-email-ada@thorsis.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1500984024-26403-4-git-send-email-ada@thorsis.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2005 Lines: 51 On Tue, 25 Jul 2017, Alexander Dahl wrote: > The converter function for translating ns timings in register values was > initialized with a wrong function pointer. This resulted in wrong > register values also for the setup and pulse registers when configuring > the EBI interface trough dts. > > Includes a small fix in a comment of the smc driver, which was probably > just a copy'n'paste mistake. > > Signed-off-by: Alexander Dahl > --- > drivers/memory/atmel-ebi.c | 2 +- > drivers/mfd/atmel-smc.c | 2 +- Acked-by: Lee Jones > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/memory/atmel-ebi.c b/drivers/memory/atmel-ebi.c > index f8a01ae..ebf69ff 100644 > --- a/drivers/memory/atmel-ebi.c > +++ b/drivers/memory/atmel-ebi.c > @@ -72,7 +72,7 @@ struct atmel_smc_timing_xlate { > { .name = nm, .converter = atmel_smc_cs_conf_set_pulse, .shift = pos} > > #define ATMEL_SMC_CYCLE_XLATE(nm, pos) \ > - { .name = nm, .converter = atmel_smc_cs_conf_set_setup, .shift = pos} > + { .name = nm, .converter = atmel_smc_cs_conf_set_cycle, .shift = pos} > > static void at91sam9_ebi_get_config(struct atmel_ebi_dev *ebid, > struct atmel_ebi_dev_config *conf) > diff --git a/drivers/mfd/atmel-smc.c b/drivers/mfd/atmel-smc.c > index 954cf0f..20cc0ea 100644 > --- a/drivers/mfd/atmel-smc.c > +++ b/drivers/mfd/atmel-smc.c > @@ -206,7 +206,7 @@ EXPORT_SYMBOL_GPL(atmel_smc_cs_conf_set_pulse); > * parameter > * > * This function encodes the @ncycles value as described in the datasheet > - * (section "SMC Pulse Register"), and then stores the result in the > + * (section "SMC Cycle Register"), and then stores the result in the > * @conf->setup field at @shift position. > * > * Returns -EINVAL if @shift is invalid, -ERANGE if @ncycles does not fit in -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog