Date: Wed, 26 Jul 2017 09:27:11 +0100
From: Will Deacon <will.deacon@arm.com>
To: "Leeder, Neil" <nleeder@codeaurora.org>
Cc: Mark Rutland <mark.rutland@arm.com>, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        Mark Langsdorf <mlangsdo@redhat.com>, Mark Salter <msalter@redhat.com>,
        Jon Masters <jcm@redhat.com>, Timur Tabi <timur@codeaurora.org>,
        Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH] perf: qcom_l2: fix column exclusion check
Message-ID: <20170726082710.GA31242@arm.com>
References: <1500931022-21000-1-git-send-email-nleeder@codeaurora.org>
 <20170725170105.GF12749@leverpostej>
 <95095f56-7b08-4ed9-f7e5-5d5768a75cc5@codeaurora.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <95095f56-7b08-4ed9-f7e5-5d5768a75cc5@codeaurora.org>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 985
Lines: 31

On Tue, Jul 25, 2017 at 03:43:54PM -0400, Leeder, Neil wrote:
> On 7/25/2017 1:01 PM, Mark Rutland wrote:
> > On Mon, Jul 24, 2017 at 05:17:02PM -0400, Neil Leeder wrote:
> >> The check for column exclusion did not verify that the event being
> >> checked was an L2 event, and not a software event.
> >> Software events should not be checked for column exclusion.
> >> This resulted in a group with both software and L2 events sometimes
> >> incorrectly rejecting the L2 event for column exclusion and
> >> not counting it.
> >>
> >> Add a check for PMU type before applying column exclusion logic.
> >>
> >> Signed-off-by: Neil Leeder <nleeder@codeaurora.org>
> > 
> > This looks correct, so:
> > 
> > Acked-by: Mark Rutland <mark.rutland@arm.com>
> > 
> > Should this have:
> > 
> > Fixes: 21bdbb7102edeaeb ("perf: add qcom l2 cache perf events driver")
> > 
> > ... ?
> > 
> Thanks. I'll re-post with the Fixes tag.

No need, I'll pick it up and add it when I apply.

Cheers,

Will