Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751057AbdGZItK (ORCPT ); Wed, 26 Jul 2017 04:49:10 -0400 Received: from mail.skyhub.de ([5.9.137.197]:59236 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750813AbdGZItI (ORCPT ); Wed, 26 Jul 2017 04:49:08 -0400 From: Borislav Petkov To: linux-edac Cc: Tony Luck , Mauro Carvalho Chehab , Toshimitsu Kani , "Rafael J. Wysocki" , LKML Subject: [PATCH 0/3] EDAC: Convert ghes_edac to a normal module Date: Wed, 26 Jul 2017 10:48:24 +0200 Message-Id: <20170726084827.11447-1-bp@alien8.de> X-Mailer: git-send-email 2.14.0.rc0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1773 Lines: 56 From: Borislav Petkov Hi, here's the conversion of ghes_edac to a proper module using a notifier. This is only the bare minimum stuff and we should do all outstanding work ontop. Which right now is: * platform whitelist * Tony: "Additional cleanup: edac_ghes.c should really call cper_mem_err_location() instead of doing pretty much the same thing but with subtle formatting differences ("node:%d" vs. "node: %d")." Yes, I think we should take a look at doing that eventually as a sensible cleanup. * Tony: "This driver isn't going to set the EDAC error counts since it just does: e->top_layer = -1; e->mid_layer = -1; e->low_layer = -1; " Right, that we should address by making layer 0 EDAC_MC_LAYER_SLOT and no other layers as we can't get any channel, branch or whatever DIMM topology from GHES. At least I'm not aware of any. But that should be enough as this info is good enough for pinpointing the DIMM. From our discussion with Tony: >> The FRU identifier is: >> >> "The module number of the memory error location. (NODE, CARD, and MODULE >> should provide the information necessary to identify the failing FRU)." > > Sounds pretty good. Generally people don't care about the channel. They > want to know which DIMM to replace. This will give them what they want. Thanks. Borislav Petkov (3): EDAC: Add edac_pr_err/info macros ACPI/GHES: Add an EDAC notifier chain EDAC, ghes: Make it a proper module drivers/acpi/apei/ghes.c | 32 +++++++----- drivers/edac/Kconfig | 4 +- drivers/edac/edac_mc.h | 3 ++ drivers/edac/ghes_edac.c | 129 ++++++++++++++++++++++++----------------------- include/acpi/ghes.h | 27 +--------- 5 files changed, 93 insertions(+), 102 deletions(-) -- 2.14.0.rc0