Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751551AbdGZKHX (ORCPT ); Wed, 26 Jul 2017 06:07:23 -0400 Received: from mx2.suse.de ([195.135.220.15]:44144 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750964AbdGZKHW (ORCPT ); Wed, 26 Jul 2017 06:07:22 -0400 Date: Wed, 26 Jul 2017 12:07:18 +0200 From: Michal Hocko To: Mike Kravetz Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Matthew Wilcox , akpm@linux-foundation.org, ak@linux.intel.com, mtk.manpages@gmail.com, Davidlohr Bueso , khandual@linux.vnet.ibm.com, aneesh.kumar@linux.vnet.ibm.com, aarcange@redhat.com Subject: Re: [RFC PATCH 3/3] mm: shm: Use new hugetlb size encoding definitions Message-ID: <20170726100718.GG2981@dhcp22.suse.cz> References: <20170328175408.GD7838@bombadil.infradead.org> <1500330481-28476-1-git-send-email-mike.kravetz@oracle.com> <1500330481-28476-4-git-send-email-mike.kravetz@oracle.com> <20170726095338.GF2981@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170726095338.GF2981@dhcp22.suse.cz> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1097 Lines: 30 On Wed 26-07-17 11:53:38, Michal Hocko wrote: > On Mon 17-07-17 15:28:01, Mike Kravetz wrote: > > Use the common definitions from hugetlb_encode.h header file for > > encoding hugetlb size definitions in shmget system call flags. In > > addition, move these definitions to the from the internal to user > > (uapi) header file. > > s@to the from@from@ > > > > > Suggested-by: Matthew Wilcox > > Signed-off-by: Mike Kravetz > > with s@HUGETLB_FLAG_ENCODE__16GB@HUGETLB_FLAG_ENCODE_16GB@ > > Acked-by: Michal Hocko Btw. man page mentions only 2MB and 1GB, we should document others and note that each arch might support only subset of them > > +#define MAP_HUGE_512KB HUGETLB_FLAG_ENCODE_512KB > > +#define MAP_HUGE_1MB HUGETLB_FLAG_ENCODE_1MB > > +#define MAP_HUGE_2MB HUGETLB_FLAG_ENCODE_2MB > > +#define MAP_HUGE_8MB HUGETLB_FLAG_ENCODE_8MB > > +#define MAP_HUGE_16MB HUGETLB_FLAG_ENCODE_16MB > > +#define MAP_HUGE_1GB HUGETLB_FLAG_ENCODE_1GB > > +#define MAP_HUGE_16GB HUGETLB_FLAG_ENCODE__16GB -- Michal Hocko SUSE Labs