Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751813AbdGZKkG (ORCPT ); Wed, 26 Jul 2017 06:40:06 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:54737 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751603AbdGZKkC (ORCPT ); Wed, 26 Jul 2017 06:40:02 -0400 Date: Wed, 26 Jul 2017 12:40:00 +0200 From: Pavel Machek To: Sebastian Reichel Cc: Sebastian Reichel , Tomi Valkeinen , Tony Lindgren , Laurent Pinchart , dri-devel@lists.freedesktop.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCHv1 02/14] drm/omap: drop incorrect comment Message-ID: <20170726104000.GB3598@amd> References: <20170724173311.27170-1-sebastian.reichel@collabora.co.uk> <20170724173311.27170-3-sebastian.reichel@collabora.co.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="QKdGvSO+nmPlgiQ/" Content-Disposition: inline In-Reply-To: <20170724173311.27170-3-sebastian.reichel@collabora.co.uk> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1686 Lines: 54 --QKdGvSO+nmPlgiQ/ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon 2017-07-24 19:32:59, Sebastian Reichel wrote: > The wrappers have been removed in commit 5a35876e2830 > (drm: omapdrm: Remove manual update display support) > and will not be reintroduced, since the normal sys > functions properly call the dirty callback. >=20 > Signed-off-by: Sebastian Reichel Acked-by: Pavel Machek > --- > drivers/gpu/drm/omapdrm/omap_fbdev.c | 3 --- > 1 file changed, 3 deletions(-) >=20 > diff --git a/drivers/gpu/drm/omapdrm/omap_fbdev.c b/drivers/gpu/drm/omapd= rm/omap_fbdev.c > index daf81a0a2899..929a3ef0fba0 100644 > --- a/drivers/gpu/drm/omapdrm/omap_fbdev.c > +++ b/drivers/gpu/drm/omapdrm/omap_fbdev.c > @@ -84,9 +84,6 @@ static struct fb_ops omap_fb_ops =3D { > .owner =3D THIS_MODULE, > DRM_FB_HELPER_DEFAULT_OPS, > =20 > - /* Note: to properly handle manual update displays, we wrap the > - * basic fbdev ops which write to the framebuffer > - */ > .fb_read =3D drm_fb_helper_sys_read, > .fb_write =3D drm_fb_helper_sys_write, > .fb_fillrect =3D drm_fb_helper_sys_fillrect, --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --QKdGvSO+nmPlgiQ/ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAll4cYAACgkQMOfwapXb+vKXUQCgsPMQ55MURJ69/t0shRZy2aM0 Fg0Anj2Grq9tSlaVAepYwTW78y6N8Vhm =xyXx -----END PGP SIGNATURE----- --QKdGvSO+nmPlgiQ/--