Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751471AbdGZNXq (ORCPT ); Wed, 26 Jul 2017 09:23:46 -0400 Received: from Galois.linutronix.de ([146.0.238.70]:48706 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751325AbdGZNXp (ORCPT ); Wed, 26 Jul 2017 09:23:45 -0400 Date: Wed, 26 Jul 2017 15:23:37 +0200 (CEST) From: Thomas Gleixner To: Joerg Roedel cc: Artem Savkov , iommu@lists.linux-foundation.org, x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] iommu/amd: Fix schedule-while-atomic BUG in initialization code In-Reply-To: <20170726122614.GP15833@8bytes.org> Message-ID: References: <20170725135618.hev4vj7w24gm3a5q@shodan.usersys.redhat.com> <20170726122614.GP15833@8bytes.org> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 279 Lines: 6 On Wed, 26 Jul 2017, Joerg Roedel wrote: > Yes, that should fix it, but I think its better to just move the > register_syscore_ops() call to a later initialization step, like in the > patch below. I tested it an will queue it to my iommu/fixes branch. Fair enough. Acked-by-me.