Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751884AbdGZNhg (ORCPT ); Wed, 26 Jul 2017 09:37:36 -0400 Received: from mail-io0-f194.google.com ([209.85.223.194]:37979 "EHLO mail-io0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751857AbdGZNhe (ORCPT ); Wed, 26 Jul 2017 09:37:34 -0400 Subject: Re: [REGRESSION 4.13-rc] NFS returns -EACCESS at the first read To: Takashi Iwai Cc: Trond Myklebust , Anna Schumaker , linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org References: From: Anna Schumaker Message-ID: <0b39602f-b92f-bc65-1116-fcf446232849@gmail.com> Date: Wed, 26 Jul 2017 09:37:31 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1404 Lines: 45 On 07/26/2017 09:30 AM, Takashi Iwai wrote: > On Wed, 26 Jul 2017 14:57:07 +0200, > Anna Schumaker wrote: >> >> Hi Takashi, >> >> On 07/26/2017 08:54 AM, Takashi Iwai wrote: >>> Hi, >>> >>> I seem hitting a regression of NFS client on the today's Linus git >>> tree. The symptom is that the file read over NFS returns occasionally >>> -EACCESS at the first read. When I try to read the same file again >>> (or do some other thing), I can read it successfully. >>> >>> The git bisection leaded to the commit >>> bd8b2441742b49c76bec707757bd9c028ea9838e >>> NFS: Store the raw NFS access mask in the inode's access cache >>> >>> >>> Any further hint for debugging? >> >> Does the patch in this email thread help? http://www.spinics.net/lists/linux-nfs/msg64930.html > > Thanks, I gave it a shot and the result looks good. Feel free to my > tested-by tag: > Tested-by: Takashi Iwai > > > Though, when I look around the code, I feel somehow uneasy by that > still MAY_XXX is used for nfs_access_entry.mask, e.g. in > nfs3_proc_access() or nfs4_proc_access(). Are these function OK > without the similar conversion? I just started looking at that at the end of the day yesterday. I think they work by accident, since all the bits in the mask are set by nfs_do_access(). They should probably be converted, but I don't think it's urgent. Anna > > > thanks, > > Takashi >