Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751599AbdGZOLN (ORCPT ); Wed, 26 Jul 2017 10:11:13 -0400 Received: from mail.kernel.org ([198.145.29.99]:45396 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750783AbdGZOLL (ORCPT ); Wed, 26 Jul 2017 10:11:11 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D034022BD1 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=robh@kernel.org MIME-Version: 1.0 In-Reply-To: <87r2x35w9v.fsf@concordia.ellerman.id.au> References: <20170725214427.25768-1-robh@kernel.org> <20170725214427.25768-5-robh@kernel.org> <87r2x35w9v.fsf@concordia.ellerman.id.au> From: Rob Herring Date: Wed, 26 Jul 2017 09:10:49 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 4/4] of/fdt: only store the device node basename in full_name To: Michael Ellerman Cc: "devicetree@vger.kernel.org" , linuxppc-dev , "linux-kernel@vger.kernel.org" , Frank Rowand , Benjamin Herrenschmidt , Paul Mackerras Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1281 Lines: 28 On Wed, Jul 26, 2017 at 5:26 AM, Michael Ellerman wrote: > Rob Herring writes: > >> With dependencies on a statically allocated full path name converted to >> use %pOF format specifier, we can store just the basename of node, and >> the unflattening of the FDT can be simplified. >> >> This commit will affect the remaining users of full_name. After >> analyzing these users, the remaining cases should only change some print >> messages. The main users of full_name are providing a name for struct >> resource. The resource names shouldn't be important other than providing >> /proc/iomem names. >> >> We no longer distinguish between pre and post 0x10 dtb formats as either >> a full path or basename will work. However, less than 0x10 formats have >> been broken since the conversion to use libfdt (and no one has cared). > > For the record - yes we did care. It broke booting with old versions of > kexec, and it was a royal P.I.T.# to debug :D Sorry, I forgot about that one. I'll drop the statement. I had gone back and looked and only found the issue on mpc8323 booting[1] which was an issue with libfdt having more checks on the fdt. I proposed some fixes, but never heard back on that. Rob [1] https://lkml.org/lkml/2015/6/10/820