Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751661AbdGZObm (ORCPT ); Wed, 26 Jul 2017 10:31:42 -0400 Received: from mail-oi0-f67.google.com ([209.85.218.67]:38649 "EHLO mail-oi0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751021AbdGZObj (ORCPT ); Wed, 26 Jul 2017 10:31:39 -0400 MIME-Version: 1.0 In-Reply-To: <10646277.hB6jvi1uWb@amdc3058> References: <20170726135816.2216688-1-arnd@arndb.de> <10646277.hB6jvi1uWb@amdc3058> From: Arnd Bergmann Date: Wed, 26 Jul 2017 16:31:38 +0200 X-Google-Sender-Auth: NifrBjXvilUutcEefRUThY8NQOs Message-ID: Subject: Re: [PATCH RESEND] fbdev: omapfb: remove unused variable To: Bartlomiej Zolnierkiewicz Cc: dri-devel , Tomi Valkeinen , Laurent Pinchart , linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org, Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1141 Lines: 32 On Wed, Jul 26, 2017 at 4:27 PM, Bartlomiej Zolnierkiewicz wrote: > > Hi, > > On Wednesday, July 26, 2017 03:57:55 PM Arnd Bergmann wrote: >> Removing the default display name left a harmless warning: >> >> fbdev/omap2/omapfb/dss/core.c: In function 'omap_dss_probe': >> fbdev/omap2/omapfb/dss/core.c:196:30: error: unused variable 'pdata' [-Werror=unused-variable] >> >> This removes the now-unused variable as well. >> >> Fixes: 278cba7eaf54 ("drm: omapdrm: Remove unused default display name support") >> Signed-off-by: Arnd Bergmann >> Reviewed-by: Laurent Pinchart >> --- >> Originally submitted on June 9, no reply other than the Reviewed-by tag. >> The patch is still needed > > It is not lost and will be queued for 4.13 fbdev fixes pull request. Ok, thanks a lot! > [ The guilty commit went through DRM tree and pulling it into fbdev > tree just to fix the warning was not feasible.. ] Yes, I was originally hoping the fix could be merged along with the patch that introduced the bug. I may have messed up the Cc list for that though. Arnd