Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752090AbdGZOem (ORCPT ); Wed, 26 Jul 2017 10:34:42 -0400 Received: from mail.kernel.org ([198.145.29.99]:54176 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751753AbdGZOej (ORCPT ); Wed, 26 Jul 2017 10:34:39 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 51B8222CAE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=robh@kernel.org MIME-Version: 1.0 In-Reply-To: <063D6719AE5E284EB5DD2968C1650D6DD00419B2@AcuExch.aculab.com> References: <20170725214427.25768-1-robh@kernel.org> <20170725214427.25768-4-robh@kernel.org> <063D6719AE5E284EB5DD2968C1650D6DD00419B2@AcuExch.aculab.com> From: Rob Herring Date: Wed, 26 Jul 2017 09:34:17 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 3/4] powerpc: pseries: only store the device node basename in full_name To: David Laight Cc: "devicetree@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , Frank Rowand , "linux-kernel@vger.kernel.org" , Paul Mackerras Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1235 Lines: 33 On Wed, Jul 26, 2017 at 5:07 AM, David Laight wrote: > From: Rob Herring >> Sent: 25 July 2017 22:44 >> With dependencies on full_name containing the entire device node path >> removed, stop storing the full_name in nodes created by >> dlpar_configure_connector() and pSeries_reconfig_add_node(). > ... >> dn = kzalloc(sizeof(*dn), GFP_KERNEL); >> if (!dn) >> return NULL; >> >> name = (char *)ccwa + be32_to_cpu(ccwa->name_offset); >> - dn->full_name = kasprintf(GFP_KERNEL, "%s/%s", path, name); >> + dn->full_name = kasprintf(GFP_KERNEL, "%s", name); > > Isn't this just strdup()? Yes, it can be simplified to that now. > Perhaps you should rename full_name to name - since it is no longer 'full'? Ideally, yes. However, we still have users in other places tree wide (which should still work with the change) and I don't think it is worth the additional churn. Also, we already have "name" as that is the node name without the unit-address. I'd like to get rid of that, but name is special in that it is exposed as a property too. Finally, full_name is still the full path on Sparc. > Maybe you could do a single malloc() for both 'dn' and the name? Sure. Rob