Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751657AbdGZOiT (ORCPT ); Wed, 26 Jul 2017 10:38:19 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:35808 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750867AbdGZOiR (ORCPT ); Wed, 26 Jul 2017 10:38:17 -0400 Date: Wed, 26 Jul 2017 16:38:12 +0200 From: Daniel Vetter To: Saurabh Sengar Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, airlied@linux.ie, saurabhs@xilinx.com, dineshk@xilinx.com Subject: Re: [PATCH] drm: adding SDI to drm_connector_enum_list Message-ID: <20170726143811.jmytjvdr7xkl5lyx@phenom.ffwll.local> Mail-Followup-To: Saurabh Sengar , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, airlied@linux.ie, saurabhs@xilinx.com, dineshk@xilinx.com References: <1501044769-14603-1-git-send-email-saurabhs@xilinx.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1501044769-14603-1-git-send-email-saurabhs@xilinx.com> X-Operating-System: Linux phenom 4.11.0-2-amd64 User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1756 Lines: 53 On Wed, Jul 26, 2017 at 10:22:49AM +0530, Saurabh Sengar wrote: > adding SDI to drm connector list > > Signed-off-by: Saurabh Sengar This is an uapi change, i.e. userspace needs to be updated. Do you _really_ need this? I'd recommend to just use something existing (go with VIRTUAL maybe, not sure). Either way, needs to come together with the actual users and userspace side patches. If you really want this. -Daniel > --- > drivers/gpu/drm/drm_connector.c | 1 + > include/uapi/drm/drm_mode.h | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.c > index 2db7fb5..ea48ddb 100644 > --- a/drivers/gpu/drm/drm_connector.c > +++ b/drivers/gpu/drm/drm_connector.c > @@ -86,6 +86,7 @@ static struct drm_conn_prop_enum_list drm_connector_enum_list[] = { > { DRM_MODE_CONNECTOR_VIRTUAL, "Virtual" }, > { DRM_MODE_CONNECTOR_DSI, "DSI" }, > { DRM_MODE_CONNECTOR_DPI, "DPI" }, > + { DRM_MODE_CONNECTOR_SDI, "SDI" }, > }; > > void drm_connector_ida_init(void) > diff --git a/include/uapi/drm/drm_mode.h b/include/uapi/drm/drm_mode.h > index df0e350..9b8d204 100644 > --- a/include/uapi/drm/drm_mode.h > +++ b/include/uapi/drm/drm_mode.h > @@ -247,6 +247,7 @@ struct drm_mode_get_encoder { > #define DRM_MODE_CONNECTOR_VIRTUAL 15 > #define DRM_MODE_CONNECTOR_DSI 16 > #define DRM_MODE_CONNECTOR_DPI 17 > +#define DRM_MODE_CONNECTOR_SDI 18 > > struct drm_mode_get_connector { > > -- > 2.7.4 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch