Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751792AbdGZPiQ (ORCPT ); Wed, 26 Jul 2017 11:38:16 -0400 Received: from mail-oi0-f67.google.com ([209.85.218.67]:33802 "EHLO mail-oi0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751738AbdGZPiM (ORCPT ); Wed, 26 Jul 2017 11:38:12 -0400 MIME-Version: 1.0 In-Reply-To: <20170726135312.2214309-2-arnd@arndb.de> References: <20170726135312.2214309-1-arnd@arndb.de> <20170726135312.2214309-2-arnd@arndb.de> From: Andy Shevchenko Date: Wed, 26 Jul 2017 18:38:10 +0300 Message-ID: Subject: Re: [PATCH 1/3] backlight: always select BACKLIGHT_LCD_SUPPORT for BACKLIGHT_CLASS_DEVICE To: Arnd Bergmann Cc: dri-devel@lists.freedesktop.org, "Rafael J. Wysocki" , Len Brown , Lucas Stach , Russell King , Christian Gmeiner , David Airlie , Patrik Jakobsson , Daniel Vetter , Jani Nikula , Ben Skeggs , Darren Hart , Andy Shevchenko , Jens Frederich , Daniel Drake , Jon Nettleton , Greg Kroah-Hartman , "linux-acpi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , etnaviv@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, nouveau@lists.freedesktop.org, Platform Driver , devel@driverdev.osuosl.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id v6QFcJFr003651 Content-Length: 1804 Lines: 39 On Wed, Jul 26, 2017 at 4:53 PM, Arnd Bergmann wrote: > randconfig builds occasionally produce this Kconfig warning: > > warning: (DRM_RADEON && DRM_AMDGPU && DRM_NOUVEAU && DRM_I915 && DRM_GMA500 && DRM_SHMOBILE && DRM_TILCDC && DRM_FSL_DCU && DRM_TINYDRM && DRM_PARADE_PS8622 && FB_BACKLIGHT && FB_ARMCLCD && FB_MX3 && USB_APPLEDISPLAY && FB_OLPC_DCON && ACPI_CMPC && SAMSUNG_Q10) selects BACKLIGHT_CLASS_DEVICE which has unmet direct dependencies (HAS_IOMEM && BACKLIGHT_LCD_SUPPORT) > > It turns out that amost all users of BACKLIGHT_CLASS_DEVICE also select > BACKLIGHT_LCD_SUPPORT, but not all of them do. This makes the remaining > ones behave like the others. > > It would probably be best to rework the way those two options related > entirely, but for now this takes the simpler and safer approach to > fix the warnings without introducing regressions. > diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig > index 80b87954f6dd..e0ca673bf564 100644 > --- a/drivers/platform/x86/Kconfig > +++ b/drivers/platform/x86/Kconfig > @@ -785,6 +785,7 @@ config ACPI_CMPC > depends on RFKILL || RFKILL=n > select INPUT > select BACKLIGHT_CLASS_DEVICE > + select BACKLIGHT_LCD_SUPPORT > default n > help > Support for Intel Classmate PC ACPI devices, including some > @@ -1000,6 +1001,7 @@ config SAMSUNG_Q10 > tristate "Samsung Q10 Extras" > depends on ACPI > select BACKLIGHT_CLASS_DEVICE > + select BACKLIGHT_LCD_SUPPORT > ---help--- > This driver provides support for backlight control on Samsung Q10 > and related laptops, including Dell Latitude X200. Acked-by: Andy Shevchenko -- With Best Regards, Andy Shevchenko