Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751451AbdGZPpX (ORCPT ); Wed, 26 Jul 2017 11:45:23 -0400 Received: from mail-pf0-f194.google.com ([209.85.192.194]:36384 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750867AbdGZPpV (ORCPT ); Wed, 26 Jul 2017 11:45:21 -0400 Date: Wed, 26 Jul 2017 17:45:07 +0200 From: Krzysztof Kozlowski To: Arvind Yadav Cc: perex@perex.cz, tiwai@suse.com, broonie@kernel.org, sbkim73@samsung.com, lgirdwood@gmail.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 01/11] ASoC: samsung: s3c2412: Handle return value of clk_prepare_enable. Message-ID: <20170726154507.GA2577@kozik-book> References: <84c0014d4dbd466f52c45d8efbd2c1080d8174fb.1501047400.git.arvind.yadav.cs@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <84c0014d4dbd466f52c45d8efbd2c1080d8174fb.1501047400.git.arvind.yadav.cs@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1193 Lines: 31 On Wed, Jul 26, 2017 at 11:15:25AM +0530, Arvind Yadav wrote: > clk_prepare_enable() can fail here and we must check its return value. > > Signed-off-by: Arvind Yadav > --- > Chnage in v2 : > Error handling for things done in s3c_i2sv2_probe(). > > sound/soc/samsung/s3c2412-i2s.c | 12 ++++++++++-- > 1 file changed, 10 insertions(+), 2 deletions(-) > > diff --git a/sound/soc/samsung/s3c2412-i2s.c b/sound/soc/samsung/s3c2412-i2s.c > index 0a47182..0b96927 100644 > --- a/sound/soc/samsung/s3c2412-i2s.c > +++ b/sound/soc/samsung/s3c2412-i2s.c > @@ -65,13 +65,16 @@ static int s3c2412_i2s_probe(struct snd_soc_dai *dai) > s3c2412_i2s.iis_cclk = devm_clk_get(dai->dev, "i2sclk"); > if (IS_ERR(s3c2412_i2s.iis_cclk)) { > pr_err("failed to get i2sclk clock\n"); > - return PTR_ERR(s3c2412_i2s.iis_cclk); > + ret = PTR_ERR(s3c2412_i2s.iis_cclk); > + goto err; No, this is kind of messy and error-prone. I think that each unit should rather clean by itself. You should not touch s3c_i2sv2 stuff directly. Instead define a s3c_i2sv2_cleanup() (or remove() to match the convention?) and call it here on error-paths. Best regards, Krzysztof