Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751210AbdGZSeh (ORCPT ); Wed, 26 Jul 2017 14:34:37 -0400 Received: from mail.kernel.org ([198.145.29.99]:34320 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750897AbdGZSef (ORCPT ); Wed, 26 Jul 2017 14:34:35 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D62C022CA0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=atull@kernel.org MIME-Version: 1.0 In-Reply-To: <1498441938-14046-5-git-send-email-hao.wu@intel.com> References: <1498441938-14046-1-git-send-email-hao.wu@intel.com> <1498441938-14046-5-git-send-email-hao.wu@intel.com> From: Alan Tull Date: Wed, 26 Jul 2017 13:33:53 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 04/22] fpga: mgr: add region_id to fpga_image_info To: Wu Hao Cc: Moritz Fischer , linux-fpga@vger.kernel.org, linux-kernel , linux-api@vger.kernel.org, "Kang, Luwei" , "Zhang, Yi Z" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 917 Lines: 34 On Sun, Jun 25, 2017 at 8:52 PM, Wu Hao wrote: Hi Hao, > This patch adds region_id to fpga_image_info data structure, it > allows driver to pass region id information to fpga-mgr via > fpga_image_info for fpga reconfiguration function. > > Signed-off-by: Wu Hao > --- > include/linux/fpga/fpga-mgr.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/linux/fpga/fpga-mgr.h b/include/linux/fpga/fpga-mgr.h > index 66d0e32..b222a57 100644 > --- a/include/linux/fpga/fpga-mgr.h > +++ b/include/linux/fpga/fpga-mgr.h > @@ -95,6 +95,7 @@ struct fpga_image_info { > struct sg_table *sgt; > const char *buf; > size_t count; > + int region_id; Please add a line to document this region_id above where all the other struct members are documented. Alan > #ifdef CONFIG_OF > struct device_node *overlay; > #endif > -- > 1.8.3.1 >