Date: Wed, 26 Jul 2017 20:37:41 +0200
From: Jonathan =?utf-8?Q?Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>
To: Palmer Dabbelt <palmer@dabbelt.com>
Cc: j.neuschaefer@gmx.net, patches@groups.riscv.org,
        Olof Johansson <olof@lixom.net>, Arnd Bergmann <arnd@arndb.de>,
        akpm@linux-foundation.org, albert@sifive.com,
        yamada.masahiro@socionext.com, mmarek@suse.com, will.deacon@arm.com,
        peterz@infradead.org, boqun.feng@gmail.com, mingo@redhat.com,
        daniel.lezcano@linaro.org, tglx@linutronix.de, jason@lakedaemon.net,
        marc.zyngier@arm.com, gregkh@linuxfoundation.org, jslaby@suse.com,
        davem@davemloft.net, mchehab@kernel.org, sfr@canb.auug.org.au,
        fweisbec@gmail.com, viro@zeniv.linux.org.uk, mcgrof@kernel.org,
        dledford@redhat.com, bart.vanassche@sandisk.com,
        sstabellini@kernel.org, daniel.vetter@ffwll.ch, mpe@ellerman.id.au,
        msalter@redhat.com, nicolas.dichtel@6wind.com, james.hogan@imgtec.com,
        paul.gortmaker@windriver.com, linux@roeck-us.net,
        heiko.carstens@de.ibm.com, schwidefsky@de.ibm.com,
        linux-kernel@vger.kernel.org
Subject: Re: [patches] [PATCH 17/17] RISC-V: Build Infastructure
Message-ID: <20170726183740.uemls2y6ktpngpim@latitude>
References: <20170726025717.lob7jlrb6ipa6rel@latitude>
 <mhng-a6f1d7ca-d517-473e-9caf-133cdda31339@palmer-si-x1c4>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
        protocol="application/pgp-signature"; boundary="e3wvo227f53jya42"
Content-Disposition: inline
In-Reply-To: <mhng-a6f1d7ca-d517-473e-9caf-133cdda31339@palmer-si-x1c4>
User-Agent: NeoMutt/20170113 (1.7.2)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 3649
Lines: 108


--e3wvo227f53jya42
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Jul 25, 2017 at 10:20:50PM -0700, Palmer Dabbelt wrote:
> On Tue, 25 Jul 2017 19:57:17 PDT (-0700), j.neuschaefer@gmx.net wrote:
> > On Tue, Jul 11, 2017 at 06:31:30PM -0700, Palmer Dabbelt wrote:
[...]
> >> +config ISA_C
> >> +	bool "Emit compressed instructions when building Linux"
> >
> > As a user, I'd prefer to have slightly more globally-recognisable names
> > than ISA_<single letter> for RISC-V instruction set architecture
> > extensions. A quick "git grep -A2 'config ISA'" shows the following
> > Kconfig symbols:
> >
> > * ISA, ISA_BUS_API, ISA_DMA_API, ISAPNP:
> >   Settings related to the historic ISA bus.
> > * ISA_ARCOMPACT/ISA_ARCV2 (arch/arc),
> >   ISA_M32R/ISA_M32R2/ISA_DSP_LEVEL2/ISA_DUAL_ISSUE (arch/m32r):
> >   Instruction set options.
> >
> > Four out of the six instruction set options have ARC/M32R in the name,
> > and I think that makes things slightly more readable. Therefore I
> > humbly propose something longer, and with a hint of RISC-V in the name,
> > such as ISA_RVC.
> >
> > (Take this with a grain of salt, perhaps.)
>=20
> Good timing: I was about to submit a v6 patch set.  I'm cool with
> CONFIG_ISA_RVC and friends, do you mind submitting a patch?

I'm not sure about ISA_A, because as I understand the mails in one of
the previous review threads, RVA is now required by Linux, so there
shouldn't be a need for CONFIG_ISA_A (or an equivalent option).

CONFIG_RISCV_ISA_C (which Arnd suggested) makes it even clearer that
these are RISC-V related options.

Here's my patch, for reference (untested, because I currently don't have
a riscv compiler installed):


Subject: [PATCH] RISC-V: Rename CONFIG_ISA_C to CONFIG_ISA_RVC

To make it clearer that ISA_C is a RISC-V related option, rename it to
ISA_RVC.

Signed-off-by: Jonathan Neusch=C3=A4fer <j.neuschaefer@gmx.net>
---
 arch/riscv/Kconfig  | 2 +-
 arch/riscv/Makefile | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig
index cc274bbc29a7..8c43e5c73892 100644
--- a/arch/riscv/Kconfig
+++ b/arch/riscv/Kconfig
@@ -135,7 +135,7 @@ config TUNE_GENERIC
=20
 endchoice
=20
-config ISA_C
+config ISA_RVC
 	bool "Emit compressed instructions when building Linux"
 	default n
 	help
diff --git a/arch/riscv/Makefile b/arch/riscv/Makefile
index 66c4a5e383f9..7ac91bcf9fe7 100644
--- a/arch/riscv/Makefile
+++ b/arch/riscv/Makefile
@@ -40,7 +40,7 @@ KBUILD_CFLAGS +=3D -Wall
 ifeq ($(CONFIG_ISA_A),y)
 	KBUILD_ARCH_A =3D a
 endif
-ifeq ($(CONFIG_ISA_C),y)
+ifeq ($(CONFIG_ISA_RVC),y)
 	KBUILD_ARCH_C =3D c
 endif
=20
--=20
2.11.0


--e3wvo227f53jya42
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAABAgAGBQJZeOFbAAoJEAgwRJqO81/bKZoQAKgC0MyW1lMhuadntrZ9Cy1+
4QFAeVOKlOv3MW7seyccWYDVLFBW6a6R1j3d+bEeT8ZpqFzK5a19F58TIFGkPMuP
GI9OYQQlGAuaTpamGdnXMtvBLtX/dFiB4yGLWWSitF2w6Ra+FvGeIOrU58J4k59P
Xn3tvet8/exxjcnbsEEFi8GQKwaY5/6/DHB9X7mWXDSb1NJyJLJw79TwWdxvA3bw
1zWJZvyp82y439JafH4vyKM0XSjPlgOnTZsSHMtBYih7naXTjK41UFr927HnL/hn
sO7/3Z1eVZCHINFOLl9b/qW3pCE2Psr63i9kkKNLgItwj0U9nQaTD0ns2v5yCn0q
Y9r7uPIS0IOFpvDFkqEMoFf0Pci8R1QiGCHEOSPl4uceDS3SaQ7qLgAzRsHsfxHh
FZlT7KWBcw+7RatZqyE0XdCEoAMQkCc5js13lY64I7Vm5u/eMyxmL+IAtYYFQxlt
iCxNXiQvu9hnpDEVkoODldHpug8YWBeTTH/zp9bcogbBRujYFNVloprQN0htrcXb
7AouLI58/KuI3zPKGdISkmFBG2XM0bU0IOljEKngXt3XDHLcV8Bnhw3xtTuPVYgu
hoe0O01RcYGxyudxLlv2bhiA9B+jAHQaZQHct8ytI/BCmbx7CNKKHuaSsmpDRioz
tdIiaFpMfJQoOGzqXsfO
=qWcH
-----END PGP SIGNATURE-----

--e3wvo227f53jya42--