Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751574AbdGZTzs (ORCPT ); Wed, 26 Jul 2017 15:55:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48408 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750918AbdGZTzq (ORCPT ); Wed, 26 Jul 2017 15:55:46 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 1E9E8A964C Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=jpoimboe@redhat.com Date: Wed, 26 Jul 2017 14:55:43 -0500 From: Josh Poimboeuf To: Kees Cook Cc: Andrew Morton , Linus Torvalds , Daniel Micay , Dan Williams , Mika Westerberg , Al Viro , David Howells , Heikki Krogerus , Bjorn Helgaas , Arnd Bergmann , Greg Kroah-Hartman , Mauro Carvalho Chehab , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] fortify: Use WARN instead of BUG for now Message-ID: <20170726195543.hxyb5h4smx5rskzg@treble> References: <20170726185219.GA57833@beast> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20170726185219.GA57833@beast> User-Agent: Mutt/1.6.0.1 (2016-04-01) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Wed, 26 Jul 2017 19:55:46 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 469 Lines: 16 On Wed, Jul 26, 2017 at 11:52:19AM -0700, Kees Cook wrote: > --- a/tools/objtool/check.c > +++ b/tools/objtool/check.c > @@ -156,7 +156,7 @@ static int __dead_end_function(struct objtool_file *file, struct symbol *func, > "kvm_spurious_fault", > "__reiserfs_panic", > "lbug_with_loc", > - "fortify_panic", > + "fortify_overflow", > }; If the function is no longer '__noreturn' then this entry needs to be removed from the global_noreturns list. -- Josh