Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751509AbdGZUU2 (ORCPT ); Wed, 26 Jul 2017 16:20:28 -0400 Received: from relay-b02.edpnet.be ([212.71.1.222]:53398 "EHLO relay-b02.edpnet.be" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750955AbdGZUU1 (ORCPT ); Wed, 26 Jul 2017 16:20:27 -0400 X-Greylist: delayed 899 seconds by postgrey-1.27 at vger.kernel.org; Wed, 26 Jul 2017 16:20:27 EDT X-ASG-Debug-ID: 1501099525-0a7b8d5c2d330440001-xx1T2L X-Barracuda-Envelope-From: dev.kurt@vandijck-laurijssen.be X-Barracuda-Effective-Source-IP: 77.109.102.73.adsl.dyn.edpnet.net[77.109.102.73] X-Barracuda-Apparent-Source-IP: 77.109.102.73 Date: Wed, 26 Jul 2017 22:04:03 +0200 From: Kurt Van Dijck To: Franklin S Cooper Jr Cc: Oliver Hartkopp , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, netdev@vger.kernel.org, linux-can@vger.kernel.org, wg@grandegger.com, mkl@pengutronix.de, robh+dt@kernel.org, quentin.schulz@free-electrons.com, andrew@lunn.ch Subject: Re: [PATCH 1/4] can: dev: Add support for limiting configured bitrate Message-ID: <20170726200403.GD6873@airbook.vandijck-laurijssen.be> X-ASG-Orig-Subj: Re: [PATCH 1/4] can: dev: Add support for limiting configured bitrate Mail-Followup-To: Franklin S Cooper Jr , Oliver Hartkopp , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, netdev@vger.kernel.org, linux-can@vger.kernel.org, wg@grandegger.com, mkl@pengutronix.de, robh+dt@kernel.org, quentin.schulz@free-electrons.com, andrew@lunn.ch References: <20170719233654.25908-1-fcooper@ti.com> <20170719233654.25908-2-fcooper@ti.com> <055c00f5-0775-4e35-309c-0d1c8aa0afdf@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <055c00f5-0775-4e35-309c-0d1c8aa0afdf@ti.com> User-Agent: Mutt/1.5.22 (2013-10-16) X-Barracuda-Connect: 77.109.102.73.adsl.dyn.edpnet.net[77.109.102.73] X-Barracuda-Start-Time: 1501099525 X-Barracuda-URL: https://212.71.1.222:443/cgi-mod/mark.cgi X-Barracuda-Scan-Msg-Size: 944 X-Barracuda-BRTS-Status: 1 X-Barracuda-Bayes: INNOCENT GLOBAL 0.5000 1.0000 0.7500 X-Barracuda-Spam-Score: 0.75 X-Barracuda-Spam-Status: No, SCORE=0.75 using global scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=6.0 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.3.41338 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 907 Lines: 37 Hi, I know my response is late ... > Hi Oliver > On 07/20/2017 02:43 AM, Oliver Hartkopp wrote: > > Hi Franklin, > > > > On 07/20/2017 01:36 AM, Franklin S Cooper Jr wrote: > > > >> +#ifdef CONFIG_OF > >> +void of_transceiver_is_fixed(struct net_device *dev) > >> +{ > > > > (..) > > > >> +} > >> +EXPORT_SYMBOL(of_transceiver_is_fixed); > >> +#endif > > > > I'm not sure about the naming here. > > > > As this is a CAN transceiver related option it should be named accordingly: I contest the the name too: 1) the can transceiver isn't fixed at all, it limited to the higher bitrates. 2) of_can_transceiver_is_fixed suggests to test if a transceiver is fixed, it does not suggest to load some properties from the device tree. of_can_load_transceiver looks way more clear to me. That's my opinion. The important things, like the contents of the functions, look good. Kind regards, Kurt Van Dijck