Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751515AbdGZVdX (ORCPT <rfc822;w@1wt.eu>);
        Wed, 26 Jul 2017 17:33:23 -0400
Received: from mail-io0-f169.google.com ([209.85.223.169]:35374 "EHLO
        mail-io0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750996AbdGZVdW (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 26 Jul 2017 17:33:22 -0400
MIME-Version: 1.0
In-Reply-To: <20170726195543.hxyb5h4smx5rskzg@treble>
References: <20170726185219.GA57833@beast> <20170726195543.hxyb5h4smx5rskzg@treble>
From: Kees Cook <keescook@chromium.org>
Date: Wed, 26 Jul 2017 14:33:20 -0700
X-Google-Sender-Auth: cBQhwQ9G6Hi_xpSFBuErlSUVKRQ
Message-ID: <CAGXu5jJeZqHugHFy8EX5NLdWCbgrXrMC1ypKux+uKErum8J7tw@mail.gmail.com>
Subject: Re: [PATCH v2] fortify: Use WARN instead of BUG for now
To: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Daniel Micay <danielmicay@gmail.com>,
        Dan Williams <dan.j.williams@intel.com>,
        Mika Westerberg <mika.westerberg@linux.intel.com>,
        Al Viro <viro@zeniv.linux.org.uk>, David Howells <dhowells@redhat.com>,
        Heikki Krogerus <heikki.krogerus@linux.intel.com>,
        Bjorn Helgaas <bhelgaas@google.com>, Arnd Bergmann <arnd@arndb.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 736
Lines: 24

On Wed, Jul 26, 2017 at 12:55 PM, Josh Poimboeuf <jpoimboe@redhat.com> wrote:
> On Wed, Jul 26, 2017 at 11:52:19AM -0700, Kees Cook wrote:
>> --- a/tools/objtool/check.c
>> +++ b/tools/objtool/check.c
>> @@ -156,7 +156,7 @@ static int __dead_end_function(struct objtool_file *file, struct symbol *func,
>>               "kvm_spurious_fault",
>>               "__reiserfs_panic",
>>               "lbug_with_loc",
>> -             "fortify_panic",
>> +             "fortify_overflow",
>>       };
>
> If the function is no longer '__noreturn' then this entry needs to be
> removed from the global_noreturns list.

Ah, dur, yes. Thanks! I see akpm has already merged this correction for -mm.

Thanks!

-Kees

-- 
Kees Cook
Pixel Security