Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751423AbdGZWdf (ORCPT ); Wed, 26 Jul 2017 18:33:35 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:41571 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751022AbdGZWdd (ORCPT ); Wed, 26 Jul 2017 18:33:33 -0400 Date: Thu, 27 Jul 2017 00:33:27 +0200 From: Andrew Lunn To: Aviad Krawczyk Cc: Joe Perches , davem@davemloft.net, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, bc.y@huawei.com, victor.gissin@huawei.com, zhaochen6@huawei.com, tony.qu@huawei.com Subject: Re: [PATCH V2 net-next 20/21] net-next/hinic: Add ethtool and stats Message-ID: <20170726223327.GG7966@lunn.ch> References: <1500460074.25934.33.camel@perches.com> <9df7d969-6706-d702-a674-9207f5b1c3df@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9df7d969-6706-d702-a674-9207f5b1c3df@huawei.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 548 Lines: 15 On Wed, Jul 19, 2017 at 03:36:28PM +0300, Aviad Krawczyk wrote: > Hi Joe, > > I tried to be consistent with the comments before, that requested > that we will use dev_err exclude some special cases for use netif. > > We will replace the dev_err(&netdev->dev,.. to netdev_err in the > next fix. netdev_err() should be used when possible. You just have to be careful in the probe() function, before netdev exists and you get "(NULL net_device):" or before it is registered and you get "(unnamed net_device)" instead of "eth42" etc. Andrew