Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751510AbdG0B7C (ORCPT ); Wed, 26 Jul 2017 21:59:02 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:46683 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751413AbdG0B7A (ORCPT ); Wed, 26 Jul 2017 21:59:00 -0400 To: Thomas Gleixner Cc: LKML , QLogic-Storage-Upstream@qlogic.com, martin.petersen@oracle.com, James Bottomley , linux-scsi , Christoph Hellwig , Sebastian Andrzej Siewior Subject: Re: [patch 0/5] scsi/bnx2*: Plug hotplug race, correct locking and simplify hotplug code From: "Martin K. Petersen" Organization: Oracle Corporation References: <20170724105255.715647116@linutronix.de> Date: Wed, 26 Jul 2017 21:58:38 -0400 In-Reply-To: <20170724105255.715647116@linutronix.de> (Thomas Gleixner's message of "Mon, 24 Jul 2017 12:52:55 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 690 Lines: 21 Thomas, > The conversion of the cpu hotplug locking to a percpu rwsem does not > longer allow recursive locking of the hotplug lock. > > The BNX2I and BNX2FC drivers install/remove hotplug states with the > hotplug lock held. The install/removal code acquired the hotplug lock > as well. > > While looking into this, I noticed an interesting hotplug race in the > BNX2FC driver, which could result in dereferencing a NULL pointer or > freed and potentially reused memory. > > The following series addresses these problems and as a final step on > top it simplifies the hotplug code in both drivers. Applied to 4.13/scsi-fixes. Thank you! -- Martin K. Petersen Oracle Linux Engineering