Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751551AbdG0DJU (ORCPT ); Wed, 26 Jul 2017 23:09:20 -0400 Received: from mail-qk0-f196.google.com ([209.85.220.196]:35041 "EHLO mail-qk0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751423AbdG0DJT (ORCPT ); Wed, 26 Jul 2017 23:09:19 -0400 MIME-Version: 1.0 In-Reply-To: <20170725155911.ihtjkz5cuwdpwoxp@khazad-dum.debian.net> References: <1500987324-507-1-git-send-email-prarit@redhat.com> <20170725155911.ihtjkz5cuwdpwoxp@khazad-dum.debian.net> From: Len Brown Date: Wed, 26 Jul 2017 23:09:18 -0400 X-Google-Sender-Auth: 8GWcRaAjD9REqF0aUK9_RXS82s4 Message-ID: Subject: Re: [PATCH] turbostat: Running on virtual machine is not supported To: Henrique de Moraes Holschuh Cc: Prarit Bhargava , "linux-kernel@vger.kernel.org" , Len Brown Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 795 Lines: 29 Henrique, I like your suggestion, thanks! BTW. let's discuss (and patch) turbostat on linux-pm, rather than on lkml. thanks, -Len On Tue, Jul 25, 2017 at 11:59 AM, Henrique de Moraes Holschuh wrote: > On Tue, 25 Jul 2017, Prarit Bhargava wrote: >> A common way of determining if the system is a virtual machine is to >> search /proc/cpuinfo flags entry for "hypervisor". turbostat must output >> a proper error message when found. > > Maybe you could output that message only if it fails to both use > /dev/msr and perf *and* it is under a virtual machine? That would have > better forward compatibility, maybe someday /dev/msr or perf will work > inside a VM for what turbostat needs... > > -- > Henrique Holschuh -- Len Brown, Intel Open Source Technology Center