Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751515AbdG0FUp (ORCPT ); Thu, 27 Jul 2017 01:20:45 -0400 Received: from mga11.intel.com ([192.55.52.93]:22560 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750936AbdG0FUn (ORCPT ); Thu, 27 Jul 2017 01:20:43 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,418,1496127600"; d="scan'208";a="131810716" Date: Thu, 27 Jul 2017 13:14:02 +0800 From: Wu Hao To: Alan Tull Cc: Moritz Fischer , linux-fpga@vger.kernel.org, linux-kernel , linux-api@vger.kernel.org, "Kang, Luwei" , "Zhang, Yi Z" Subject: Re: [PATCH v2 04/22] fpga: mgr: add region_id to fpga_image_info Message-ID: <20170727051402.GB32273@hao-dev> References: <1498441938-14046-1-git-send-email-hao.wu@intel.com> <1498441938-14046-5-git-send-email-hao.wu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1358 Lines: 51 On Wed, Jul 26, 2017 at 01:33:53PM -0500, Alan Tull wrote: > On Sun, Jun 25, 2017 at 8:52 PM, Wu Hao wrote: > > Hi Hao, > > > This patch adds region_id to fpga_image_info data structure, it > > allows driver to pass region id information to fpga-mgr via > > fpga_image_info for fpga reconfiguration function. > > > > Signed-off-by: Wu Hao > > --- > > include/linux/fpga/fpga-mgr.h | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/include/linux/fpga/fpga-mgr.h b/include/linux/fpga/fpga-mgr.h > > index 66d0e32..b222a57 100644 > > --- a/include/linux/fpga/fpga-mgr.h > > +++ b/include/linux/fpga/fpga-mgr.h > > @@ -95,6 +95,7 @@ struct fpga_image_info { > > struct sg_table *sgt; > > const char *buf; > > size_t count; > > + int region_id; > > Please add a line to document this region_id above where all the other > struct members are documented. Hi Alan Thanks for the comments, I will fix this in the next version. * @sgt: scatter/gather table containing FPGA image * @buf: contiguous buffer containing FPGA image * @count: size of buf + * @region_id: id of target region * @overlay: Device Tree overlay */ struct fpga_image_info { Thanks Hao > > Alan > > > #ifdef CONFIG_OF > > struct device_node *overlay; > > #endif > > -- > > 1.8.3.1 > >