Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751558AbdG0Hpn (ORCPT <rfc822;w@1wt.eu>);
        Thu, 27 Jul 2017 03:45:43 -0400
Received: from smtp-out6.electric.net ([192.162.217.186]:56975 "EHLO
        smtp-out6.electric.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750992AbdG0Hpm (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 27 Jul 2017 03:45:42 -0400
From: David Laight <David.Laight@ACULAB.COM>
To: "'Brijesh Singh'" <brijesh.singh@amd.com>,
        "H. Peter Anvin" <hpa@zytor.com>, Arnd Bergmann <arnd@arndb.de>
CC: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "x86@kernel.org" <x86@kernel.org>,
        "linux-efi@vger.kernel.org" <linux-efi@vger.kernel.org>,
        "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        Fenghua Yu <fenghua.yu@intel.com>,
        Matt Fleming <matt@codeblueprint.co.uk>,
        David Howells <dhowells@redhat.com>, Paul Mackerras <paulus@samba.org>,
        Christoph Lameter <cl@linux.com>, Jonathan Corbet <corbet@lwn.net>,
        =?utf-8?B?UmFkaW0gS3JjbcOhcg==?= <rkrcmar@redhat.com>,
        Piotr Luc <piotr.luc@intel.com>, Ingo Molnar <mingo@redhat.com>,
        Dave Airlie <airlied@redhat.com>, Borislav Petkov <bp@suse.de>,
        Tom Lendacky <thomas.lendacky@amd.com>,
        Kees Cook <keescook@chromium.org>,
        "Konrad Rzeszutek Wilk" <konrad.wilk@oracle.com>,
        Reza Arbab <arbab@linux.vnet.ibm.com>,
        Andy Lutomirski <luto@kernel.org>,
        "Thomas Gleixner" <tglx@linutronix.de>,
        Laura Abbott <labbott@redhat.com>, Tony Luck <tony.luck@intel.com>,
        "Ard.Biesheuvel@zytor.com" <Ard.Biesheuvel@zytor.com>
Subject: RE: [RFC Part1 PATCH v3 13/17] x86/io: Unroll string I/O when SEV
 is active
Thread-Topic: [RFC Part1 PATCH v3 13/17] x86/io: Unroll string I/O when SEV
 is active
Thread-Index: AQHTBMr+maW+IBZqtEeA2Vfkk/FXraJkTNGggAIzVfz//+/MAIAAC0AAgADTATA=
Date: Thu, 27 Jul 2017 07:45:25 +0000
Message-ID: <063D6719AE5E284EB5DD2968C1650D6DD00436A7@AcuExch.aculab.com>
References: <20170724190757.11278-1-brijesh.singh@amd.com>
 <20170724190757.11278-14-brijesh.singh@amd.com>
 <063D6719AE5E284EB5DD2968C1650D6DD003FB85@AcuExch.aculab.com>
 <CAK8P3a3h7JpmkW7W=HwqAuWWmro=ngj6HSeiiML_=T82x-FtZQ@mail.gmail.com>
 <ed6d4ce7-97a6-f664-d7d7-4ff48bc6f06a@amd.com>
 <201707261927.v6QJR228008075@mail.zytor.com>
 <589d65a4-eb09-bae9-e8b4-a2d78ca6b509@amd.com>
In-Reply-To: <589d65a4-eb09-bae9-e8b4-a2d78ca6b509@amd.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.202.99.200]
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
X-Outbound-IP: 156.67.243.126
X-Env-From: David.Laight@ACULAB.COM
X-Proto: esmtps
X-Revdns: 
X-HELO: AcuExch.aculab.com
X-TLS: TLSv1:AES128-SHA:128
X-Authenticated_ID: 
X-PolicySMART: 3396946, 3397078
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from base64 to 8bit by nfs id v6R7jlQa029698
Content-Length: 481
Lines: 16

From: Brijesh Singh
> Sent: 26 July 2017 21:07
...
> I am not sure if I understand your concern.
> 
> Are you commenting on amount of code duplication ? If so, I can certainly improve
> and use the similar macro used into header file to generate the functions body.

If you are careful the real functions could expand the inline functions
that get used when SEV is compiled out.

Oh, if you are looking at this, can you fix memcpy_to_io()
so that it is never 'rep movsb'?

	David