Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751777AbdG0Ibk (ORCPT ); Thu, 27 Jul 2017 04:31:40 -0400 Received: from regular1.263xmail.com ([211.150.99.139]:36516 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751566AbdG0Ibi (ORCPT ); Thu, 27 Jul 2017 04:31:38 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-RL-SENDER: jeffy.chen@rock-chips.com X-FST-TO: mark.yao@rock-chips.com X-SENDER-IP: 103.29.142.67 X-LOGIN-NAME: jeffy.chen@rock-chips.com X-UNIQUE-TAG: <4c4f4b47d9154427d4f7b07dbcc092c0> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <5979A4E5.6090107@rock-chips.com> Date: Thu, 27 Jul 2017 16:31:33 +0800 From: jeffy User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:19.0) Gecko/20130126 Thunderbird/19.0 MIME-Version: 1.0 To: Mark yao , David Airlie , Heiko Stuebner CC: linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [v6,1/7] drm/rockchip: vop: initialize registers directly References: <1501049946-5877-1-git-send-email-mark.yao@rock-chips.com> In-Reply-To: <1501049946-5877-1-git-send-email-mark.yao@rock-chips.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 565 Lines: 16 Hi mark, On 07/26/2017 02:19 PM, Mark yao wrote: > At present we are using init_table to initialize some > registers, but the Register init table use un-document define, > it is unreadable, and sometimes we only want to update tiny > bits, init table method is not friendly, it's diffcult to > reuse for difference chips. > > To make it clean, initialize registers directly, and drops > init_table mechanism out. > > Signed-off-by: Mark Yao > Tested-by: Heiko Stuebner Reviewed-by: Jeffy Chen