Message-ID: <5979A77C.6000304@rock-chips.com>
Date: Thu, 27 Jul 2017 16:42:36 +0800
From: jeffy <jeffy.chen@rock-chips.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:19.0) Gecko/20130126 Thunderbird/19.0
MIME-Version: 1.0
To: Mark yao <mark.yao@rock-chips.com>, David Airlie <airlied@linux.ie>,
        Heiko Stuebner <heiko@sntech.de>
CC: linux-rockchip@lists.infradead.org,
        linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org
Subject: Re: [v6,7/7] drm/rockchip: vop: rk3328: fix overlay abnormal
References: <1501049980-6239-1-git-send-email-mark.yao@rock-chips.com>
In-Reply-To: <1501049980-6239-1-git-send-email-mark.yao@rock-chips.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 602
Lines: 19

Hi mark,

On 07/26/2017 02:19 PM, Mark yao wrote:
> It's a hardware bug, all window's overlay channel reset
> value is same, hardware overlay would be die.
>
> so we must initial difference id for each overlay channel.
>
> The Channel register is supported on all vop will full design.
> Following is the details for this register
> VOP_WIN0_CTRL2
>    bit[7:4] win_rid_win0_cbr
>         axi read id of win0 cbr channel
>    bit[3:0] win_rid_win0_yrgb
>         axi read id of win0 yrgb channel
>
> Signed-off-by: Mark Yao<mark.yao@rock-chips.com>

Reviewed-by: Jeffy Chen <jeffy.chen@rock-chips.com>