Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751742AbdG0I5r (ORCPT ); Thu, 27 Jul 2017 04:57:47 -0400 Received: from mail-lf0-f67.google.com ([209.85.215.67]:34581 "EHLO mail-lf0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751678AbdG0I5n (ORCPT ); Thu, 27 Jul 2017 04:57:43 -0400 Date: Thu, 27 Jul 2017 12:59:00 +0200 From: Marcin Ciupak To: Greg Kroah-Hartman Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Oleg Drokin , Andreas Dilger , lustre-devel@lists.lustre.org Subject: Re: [PATCH v2] staging: lustre: replace simple_strtoul with kstrtoint Message-ID: <20170727105900.GA21407@gentoo.lan> References: <20170321124609.GA3896@gentoo> <20170414081631.GC16598@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170414081631.GC16598@kroah.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1603 Lines: 46 I did test it and not everything works as expected. I need to reconsider that change. Please drop this patch. Thanks, Marcin P.S. Sorry for late (sic!) response. On Fri, Apr 14, 2017 at 10:16:31AM +0200, Greg Kroah-Hartman wrote: > On Tue, Mar 21, 2017 at 01:46:09PM +0100, Marcin Ciupak wrote: > > Replace simple_strtoul with kstrtoint. > > simple_strtoul is marked for obsoletion as reported by checkpatch.pl > > > > Signed-off-by: Marcin Ciupak > > --- > > v2: > > -improving kstrtoint error handling > > -updating commit message > > > > drivers/staging/lustre/lustre/obdclass/obd_mount.c | 16 ++++++++++++---- > > 1 file changed, 12 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/staging/lustre/lustre/obdclass/obd_mount.c b/drivers/staging/lustre/lustre/obdclass/obd_mount.c > > index 8e0d4b1d86dc..42858ee5b444 100644 > > --- a/drivers/staging/lustre/lustre/obdclass/obd_mount.c > > +++ b/drivers/staging/lustre/lustre/obdclass/obd_mount.c > > @@ -924,12 +924,20 @@ static int lmd_parse(char *options, struct lustre_mount_data *lmd) > > lmd->lmd_flags |= LMD_FLG_ABORT_RECOV; > > clear++; > > } else if (strncmp(s1, "recovery_time_soft=", 19) == 0) { > > - lmd->lmd_recovery_time_soft = max_t(int, > > - simple_strtoul(s1 + 19, NULL, 10), time_min); > > + int res; > > + > > + rc = kstrtoint(s1 + 19, 10, &res); > > + if (rc) > > + goto invalid; > > + lmd->lmd_recovery_time_soft = max_t(int, res, time_min); > > Are you sure max_t is still needed here? > > And have you tested this change? > > thanks, > > greg k-h