Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751454AbdG0MfD (ORCPT ); Thu, 27 Jul 2017 08:35:03 -0400 Received: from mail-pf0-f170.google.com ([209.85.192.170]:33275 "EHLO mail-pf0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750836AbdG0MfC (ORCPT ); Thu, 27 Jul 2017 08:35:02 -0400 Date: Thu, 27 Jul 2017 21:32:28 +0900 From: Sergey Senozhatsky To: Nadav Amit Cc: Mel Gorman , Rik van Riel , Andy Lutomirski , Andrew Morton , Michal Hocko , linux-kernel@vger.kernel.org Subject: [mmots] build error: mm: prevent racy access to tlb_flush_pending Message-ID: <20170727123228.GA573@tigerII.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 818 Lines: 27 Hello, 8c636138f497b36ae95f ("mm: prevent racy access to tlb_flush_pending") kills the build kernel/fork.c: In function ‘mm_init’: kernel/fork.c:810:18: error: ‘struct mm_struct’ has no member named ‘tlb_flush_pending’; did you mean ‘tlb_flush_batched’? atomic_set(&mm->tlb_flush_pending, 0); ^~~~~~~~~~~~~~~~~ tlb_flush_batched replacing clear_tlb_flush_pending() with a direct ->tlb_flush_pending access @@ -807,7 +807,7 @@ static struct mm_struct *mm_init(struct mm_struct *mm, struct task_struct *p, mm_init_aio(mm); mm_init_owner(mm, p); mmu_notifier_mm_init(mm); - clear_tlb_flush_pending(mm); + atomic_set(&mm->tlb_flush_pending, 0); doesn't work on on !CONFIG_NUMA_BALANCING && !CONFIG_COMPACTION systems. -ss