Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751725AbdG0Mic (ORCPT ); Thu, 27 Jul 2017 08:38:32 -0400 Received: from ozlabs.org ([103.22.144.67]:34845 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751632AbdG0Mib (ORCPT ); Thu, 27 Jul 2017 08:38:31 -0400 X-powerpc-patch-notification: thanks X-powerpc-patch-commit: 4fd1bd443e80b12f0a01a45fb9a793206b41cb72 In-Reply-To: <20170721145139.9384-1-lvivier@redhat.com> To: Laurent Vivier , linux-kernel@vger.kernel.org From: Michael Ellerman Cc: Thomas Huth , linuxppc-dev@lists.ozlabs.org, Tyrel Datwyler , David Gibson Subject: Re: powerpc/pseries: Fix of_node_put() underflow during pseries remove Message-Id: <3xJBNQ0hqTz9s76@ozlabs.org> Date: Thu, 27 Jul 2017 22:38:29 +1000 (AEST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 608 Lines: 17 On Fri, 2017-07-21 at 14:51:39 UTC, Laurent Vivier wrote: > As for commit 68baf692c435 ("powerpc/pseries: Fix of_node_put() > underflow during DLPAR remove"), the call to of_node_put() > must be removed from pSeries_reconfig_remove_node(). > > dlpar_detach_node() and pSeries_reconfig_remove_node() call > of_detach_node(), and thus the node should not be released > in this case too. > > Signed-off-by: Laurent Vivier > Reviewed-by: David Gibson Applied to powerpc fixes, thanks. https://git.kernel.org/powerpc/c/4fd1bd443e80b12f0a01a45fb9a793 cheers