Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751593AbdG0N0s (ORCPT ); Thu, 27 Jul 2017 09:26:48 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:42481 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751446AbdG0N0q (ORCPT ); Thu, 27 Jul 2017 09:26:46 -0400 Date: Thu, 27 Jul 2017 15:26:25 +0200 From: Andrew Lunn To: Egil Hjelmeland Cc: corbet@lwn.net, vivien.didelot@savoirfairelinux.com, f.fainelli@gmail.com, davem@davemloft.net, kernel@pengutronix.de, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH net-next v2 06/10] net: dsa: lan9303: added sysfs node swe_bcst_throt Message-ID: <20170727132625.GA18666@lunn.ch> References: <20170725161553.30147-1-privat@egil-hjelmeland.no> <20170725161553.30147-7-privat@egil-hjelmeland.no> <20170726171423.GQ12049@lunn.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 507 Lines: 14 > Yes, this setting can be used to reduce effect of broadcast storms. So one way to solve this is to teach the software bridge about broadcast storm control. Put some rate limiting into its broadcast flood handling. Then add a switchdev call which passes this down into the switch. Or look at doing it via TC. It is just a filter selecting broadcast traffic and applying some shaping, which is what TC is all about. Generic solutions which can be used by all switches are likely to be accepted. Andrew