Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751738AbdG0NcJ (ORCPT ); Thu, 27 Jul 2017 09:32:09 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:36060 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751632AbdG0NcF (ORCPT ); Thu, 27 Jul 2017 09:32:05 -0400 Date: Thu, 27 Jul 2017 15:32:02 +0200 From: Jiri Pirko To: Andrew Lunn Cc: Egil Hjelmeland , corbet@lwn.net, vivien.didelot@savoirfairelinux.com, f.fainelli@gmail.com, davem@davemloft.net, kernel@pengutronix.de, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH net-next v2 06/10] net: dsa: lan9303: added sysfs node swe_bcst_throt Message-ID: <20170727133202.GA1875@nanopsycho> References: <20170725161553.30147-1-privat@egil-hjelmeland.no> <20170725161553.30147-7-privat@egil-hjelmeland.no> <20170726171423.GQ12049@lunn.ch> <20170727132625.GA18666@lunn.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170727132625.GA18666@lunn.ch> User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 654 Lines: 18 Thu, Jul 27, 2017 at 03:26:25PM CEST, andrew@lunn.ch wrote: >> Yes, this setting can be used to reduce effect of broadcast storms. > >So one way to solve this is to teach the software bridge about >broadcast storm control. Put some rate limiting into its broadcast >flood handling. Then add a switchdev call which passes this down into >the switch. > >Or look at doing it via TC. It is just a filter selecting broadcast >traffic and applying some shaping, which is what TC is all about. Ack. This is probably the way to do this. Definitelly no sysfs knob... > >Generic solutions which can be used by all switches are likely to be >accepted. > > Andrew