MIME-Version: 1.0
In-Reply-To: <20170727132354.GA24745@kroah.com>
References: <20170629190211.16927-1-tkjos@google.com> <20170629190211.16927-3-tkjos@google.com>
 <CANcMJZCnDLGvm+RaN5-JwNhCNA82D3t9T6idtZTzS8+iquyukw@mail.gmail.com>
 <CANcMJZDkxZ+bOnT0Otzd+FJVmd8_+aQaMSn7=qh3ex3xwaQj1w@mail.gmail.com>
 <CA+_MTtzcVGnsF6QKiJOViFxzPttoepyrB_Osa825SWMeta5r=A@mail.gmail.com>
 <CAMi1Hd0rT8Q92DiiS0h=TZ2uK07V43NSuzN6m6aM9KtRYJhNhA@mail.gmail.com> <20170727132354.GA24745@kroah.com>
From: Martijn Coenen <maco@google.com>
Date: Thu, 27 Jul 2017 15:40:10 +0200
Message-ID: <CA+_MTtyryaDDULigAqn9grveOusfMLDTknCSFZVe04rFt39yDA@mail.gmail.com>
Subject: Re: [PATCH 02/37] binder: use group leader instead of open thread
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Amit Pundir <amit.pundir@linaro.org>,
        John Stultz <john.stultz@linaro.org>, Todd Kjos <tkjos@android.com>,
        =?UTF-8?B?QXJ2ZSBIasO4bm5ldsOlZw==?= <arve@android.com>,
        devel@driverdev.osuosl.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Todd Kjos <tkjos@google.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1329
Lines: 38

Looks like this assignment somehow went missing in the upstream version:

proc->vma_vm_mm = current->group_leader->mm;

which probably causes us to bail out here in
binder_update_page_range() because proc->vma_vm_mm is NULL:

if (vma && mm != proc->vma_vm_mm) {
                        pr_err("%d: vma mm and task mm mismatch\n",
                                proc->pid);


I'll prep a patch to fix this ASAP.

On Thu, Jul 27, 2017 at 3:23 PM, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
> On Thu, Jul 27, 2017 at 02:38:30PM +0530, Amit Pundir wrote:
>> Hi,
>>
>> On 25 July 2017 at 14:43, Martijn Coenen <maco@google.com> wrote:
>> > Hi John,
>> >
>> > On Mon, Jul 24, 2017 at 11:07 PM, John Stultz <john.stultz@linaro.org> wrote:
>> >>
>> >> 12-31 16:00:36.632  2518  2584 E hw-ProcessState: Using /dev/hwbinder
>> >> failed: unable to mmap transaction memory.
>> >
>> > This doesn't look right. Is there anything in the kernel log?
>>
>> There is a slight difference in this patch and the one that got pushed
>> in android-4.9[1]. I cherry-picked those changes and got BT/WiFi
>> working again on Hikey with mainline tracking (4.13-rc2) tree.
>>
>> Regards,
>> Amit Pundir
>> [1] https://android.googlesource.com/kernel/common/+/872c26eb0776ef160447d8703779e2bce0b7230a%5E%21/#F0
>
> And what is that difference?