Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751882AbdG0Org (ORCPT ); Thu, 27 Jul 2017 10:47:36 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:34493 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751577AbdG0Ore (ORCPT ); Thu, 27 Jul 2017 10:47:34 -0400 Subject: Re: [PATCH v4 9/9] arm: dts: mt7623: add dts file for Bananapi R2 (BPI-R2) board To: sean.wang@mediatek.com, robh+dt@kernel.org, mark.rutland@arm.com, devicetree@vger.kernel.org, john@phrozen.org, linux-mediatek@lists.infradead.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <5cc5489b38fc2723c30c8cfe0d4353f967d100f3.1495683769.git.sean.wang@mediatek.com> From: Matthias Brugger Message-ID: <805ad5c4-db47-ef10-565d-b63e33a84bdf@gmail.com> Date: Thu, 27 Jul 2017 16:39:39 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <5cc5489b38fc2723c30c8cfe0d4353f967d100f3.1495683769.git.sean.wang@mediatek.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2283 Lines: 66 On 05/25/2017 06:02 AM, sean.wang@mediatek.com wrote: > From: Sean Wang > > Add support for the Bananapi R2 (BPI-R2) development board from > BIPAI KEJI. Detailed hardware information for BPI-R2 which could be > found on http://www.banana-pi.org/r2.html > > The patch currently only adds Mediatek GMAC, MT7530 Switch, the crypto > engine, USB, IR, I2S, I2C, UART, SPI, PWM, GPIO keys, GPIO LEDs and > PMIC LEDs. As to the other missing hardware and peripherals, they would > be added and integrated continuously. > > Signed-off-by: Sean Wang > Acked-by: Rob Herring > --- > Documentation/devicetree/bindings/arm/mediatek.txt | 2 + > arch/arm/boot/dts/Makefile | 1 + > arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts | 440 +++++++++++++++++++++ > 3 files changed, 443 insertions(+) > create mode 100644 arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts > [...] > diff --git a/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts b/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts > new file mode 100644 > index 0000000..72c7984 > --- /dev/null > +++ b/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts [...] > + > +ð { > + status = "okay"; > + gmac0: mac@0 { > + compatible = "mediatek,eth-mac"; > + reg = <0>; > + phy-mode = "trgmii"; > + fixed-link { > + speed = <1000>; > + full-duplex; > + pause; > + }; > + }; > + > + mdio: mdio-bus { > + switch@0 { > + compatible = "mediatek,mt7530"; > + #address-cells = <1>; > + #size-cells = <0>; > + reg = <0>; What is this reg needed for? I can't find it neither in the code nor in the bindings (mt7530 and general dsa bindings). Actually it throws a warning when compiling: arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dtb: Warning (reg_format): "reg" property in /ethernet@1b100000/mdio-bus/switch@0 has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1) arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dtb: Warning (avoid_default_addr_size): Relying on default #address-cells value for /ethernet@1b100000/mdio-bus/switch@0 arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dtb: Warning (avoid_default_addr_size): Relying on default #size-cells value for /ethernet@1b100000/mdio-bus/switch@0 Regards, Matthias