Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751543AbdG0PEt (ORCPT ); Thu, 27 Jul 2017 11:04:49 -0400 Received: from mx2.suse.de ([195.135.220.15]:38810 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751122AbdG0PEs (ORCPT ); Thu, 27 Jul 2017 11:04:48 -0400 Date: Thu, 27 Jul 2017 17:04:45 +0200 From: Joerg Roedel To: Baoquan He Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v8 01/13] iommu/amd: Detect pre enabled translation Message-ID: <20170727150445.GJ3610@suse.de> References: <1500627551-12930-1-git-send-email-bhe@redhat.com> <1500627551-12930-2-git-send-email-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1500627551-12930-2-git-send-email-bhe@redhat.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 799 Lines: 25 On Fri, Jul 21, 2017 at 04:58:59PM +0800, Baoquan He wrote: > diff --git a/drivers/iommu/amd_iommu_types.h b/drivers/iommu/amd_iommu_types.h > index 294a409e283b..d15966b62b33 100644 > --- a/drivers/iommu/amd_iommu_types.h > +++ b/drivers/iommu/amd_iommu_types.h > @@ -417,6 +417,7 @@ extern struct kmem_cache *amd_iommu_irq_cache; > #define APERTURE_PAGE_INDEX(a) (((a) >> 21) & 0x3fULL) > > > + Forgot to remove that from the diff? > /* > * This struct is used to pass information about > * incoming PPR faults around. > @@ -435,6 +436,8 @@ struct iommu_domain; > struct irq_domain; > struct amd_irte_ops; > > +#define AMD_IOMMU_FLAG_TRANS_PRE_ENABLED (1 << 0) > + > /* > * This structure contains generic data for IOMMU protection domains > * independent of their use.