Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751585AbdG0PGQ (ORCPT ); Thu, 27 Jul 2017 11:06:16 -0400 Received: from mx2.suse.de ([195.135.220.15]:38920 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751113AbdG0PGP (ORCPT ); Thu, 27 Jul 2017 11:06:15 -0400 Date: Thu, 27 Jul 2017 17:06:12 +0200 From: Joerg Roedel To: Baoquan He Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v8 02/13] iommu/amd: add several helper functions Message-ID: <20170727150612.GK3610@suse.de> References: <1500627551-12930-1-git-send-email-bhe@redhat.com> <1500627551-12930-3-git-send-email-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1500627551-12930-3-git-send-email-bhe@redhat.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1560 Lines: 49 On Fri, Jul 21, 2017 at 04:59:00PM +0800, Baoquan He wrote: > Move single iommu enabling codes into a wrapper function early_enable_iommu(). > This can make later kdump change easier. > > And also add iommu_disable_command_buffer and iommu_disable_event_buffer > for later usage. > > Signed-off-by: Baoquan He > --- > drivers/iommu/amd_iommu_init.c | 42 +++++++++++++++++++++++++++++++----------- > 1 file changed, 31 insertions(+), 11 deletions(-) > > diff --git a/drivers/iommu/amd_iommu_init.c b/drivers/iommu/amd_iommu_init.c > index e39857ce6481..4ca6e3257d92 100644 > --- a/drivers/iommu/amd_iommu_init.c > +++ b/drivers/iommu/amd_iommu_init.c > @@ -634,6 +634,14 @@ static void iommu_enable_command_buffer(struct amd_iommu *iommu) > amd_iommu_reset_cmd_buffer(iommu); > } > > +/* > + * This function disables the command buffer > + */ > +static void iommu_disable_command_buffer(struct amd_iommu *iommu) > +{ > + iommu_feature_disable(iommu, CONTROL_CMDBUF_EN); > +} > + > static void __init free_command_buffer(struct amd_iommu *iommu) > { > free_pages((unsigned long)iommu->cmd_buf, get_order(CMD_BUFFER_SIZE)); > @@ -666,6 +674,14 @@ static void iommu_enable_event_buffer(struct amd_iommu *iommu) > iommu_feature_enable(iommu, CONTROL_EVT_LOG_EN); > } > > +/* > + * This function disables the command buffer s/command buffer/event log/ > + */ > +static void iommu_disable_event_buffer(struct amd_iommu *iommu) Please also use event_log here. > +{ > + iommu_feature_disable(iommu, CONTROL_EVT_LOG_EN); > +} > +