Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751658AbdG0PPb (ORCPT <rfc822;w@1wt.eu>);
        Thu, 27 Jul 2017 11:15:31 -0400
Received: from resqmta-po-02v.sys.comcast.net ([96.114.154.161]:41828 "EHLO
        resqmta-po-02v.sys.comcast.net" rhost-flags-OK-OK-OK-OK)
        by vger.kernel.org with ESMTP id S1750836AbdG0PP3 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 27 Jul 2017 11:15:29 -0400
Date: Thu, 27 Jul 2017 10:15:26 -0500 (CDT)
From: Christopher Lameter <cl@linux.com>
X-X-Sender: cl@nuc-kabylake
To: Kees Cook <keescook@chromium.org>
cc: Alexander Popov <alex.popov@linux.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Pekka Enberg <penberg@kernel.org>,
        David Rientjes <rientjes@google.com>,
        Joonsoo Kim <iamjoonsoo.kim@lge.com>,
        "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
        Ingo Molnar <mingo@kernel.org>, Josh Triplett <josh@joshtriplett.org>,
        Andy Lutomirski <luto@kernel.org>,
        Nicolas Pitre <nicolas.pitre@linaro.org>, Tejun Heo <tj@kernel.org>,
        Daniel Mack <daniel@zonque.org>,
        Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
        Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
        Helge Deller <deller@gmx.de>, Rik van Riel <riel@redhat.com>,
        Linux-MM <linux-mm@kvack.org>, Tycho Andersen <tycho@docker.com>,
        LKML <linux-kernel@vger.kernel.org>,
        "kernel-hardening@lists.openwall.com" 
        <kernel-hardening@lists.openwall.com>
Subject: Re: [v3] mm: Add SLUB free list pointer obfuscation
In-Reply-To: <CAGXu5jLNeO-WmaQXp9z-+iw2sha-DXixtQ-fjQmahUkh0Hvxeg@mail.gmail.com>
Message-ID: <alpine.DEB.2.20.1707271014510.15182@nuc-kabylake>
References: <20170706002718.GA102852@beast> <cdd42a1b-ce15-df8c-6bd1-b0943275986f@linux.com> <CAGXu5jKRDhvqj0TU10W10hsdixN2P+hHzpYfSVvOFZy=hW72Mg@mail.gmail.com> <alpine.DEB.2.20.1707260906230.6341@nuc-kabylake> <CAGXu5jLkOjDKSZ48jOyh2voP17xXMeEnqzV_=8dGSvFmqdCZCA@mail.gmail.com>
 <alpine.DEB.2.20.1707261154140.9167@nuc-kabylake> <CAGXu5jLNeO-WmaQXp9z-+iw2sha-DXixtQ-fjQmahUkh0Hvxeg@mail.gmail.com>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
X-CMAE-Envelope: MS4wfEK8SnEVTAk3kKDRFnrYopBMUi2m77NDueZqAhgouCpaQeeqkdykoM3UA5TqvIEro9/4R+vojYbvRbS/Ip9prs/xeBGI2SmWfHYd4zSz6yG8A03V06uj
 lHb7y4qVj6dfw4mYVDzqlWjQ8xDR7V7KG4klluFcj/rQbYgLAuNYigjpRK54+Kl5KJJ3R6XS8IK+gnMEfgB9clvWIYVWGmmE554xw/MFDP/v+mea25etVZum
 vopG7xJVneu7zWegtKJa/F9GMuVX21eE8Q3R/cyP9/1+GdGS49k9ZwYJpkhJiT27Na4Cbcik49Ll92UpmP0+0fmwRg1wZhn0Lf5NLE11t1bpeGLRN5Gc074Q
 lNKdWesCHuYac89XdIILmW8j5KtMoUIPCzN3WuurWZ08IDaM+YxSosw0l4tlxW4M+vUdo6mwuoEXWN9jMt3axXTkiGbVYpCvS4iJneW8IvkBvbsYE4etoQT+
 Ww+/+jbRtuEpGEyTKF7qXzOHL44RcgZGaXMZqsRGy8DmZOgBdSuzmae286A3Cgy4SaVw7sqmrqBT03WjRdvzJgAlSBhtZJNIcFwW7yceRSJaMeo1lcdaiIto
 +Aq0VFa8ddncLoAxsk+IbQ6wLVGyeU8MjAylE4GKrq86W34OmWFXH6jXvlHK1ljbr1VRG4Fgq1+YzJKShiv4qkFAQ0PbDPSzKeNNoWr7lqsJIhz6yARmUNbX
 hzTw+D5Pe1gFnqrVxEZ9U4ehYi9/3kDjCI8kupy7Fd5jXR3mHrlpZnV78nZOlEA47Yg05mILp9tlpxtBf4hPUWDIm2ccLoMl
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 435
Lines: 14

On Wed, 26 Jul 2017, Kees Cook wrote:

> > Although in either case we are adding code to the fastpath...
>
> While I'd like it unconditionally, I think Alexander's proposal was to
> put it behind CONFIG_SLAB_FREELIST_HARDENED.

Sounds good.

> BTW, while I've got your attention, can you Ack the other patch? I
> sent a v4 for the pointer obfuscation, which we really need:
> https://lkml.org/lkml/2017/7/26/4

Just looked through it.