Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751635AbdG0Pi2 (ORCPT ); Thu, 27 Jul 2017 11:38:28 -0400 Received: from mx2.suse.de ([195.135.220.15]:41601 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751561AbdG0Pi1 (ORCPT ); Thu, 27 Jul 2017 11:38:27 -0400 Date: Thu, 27 Jul 2017 17:38:25 +0200 From: Joerg Roedel To: Baoquan He Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v8 06/13] iommu/amd: copy old trans table from old kernel Message-ID: <20170727153825.GM3610@suse.de> References: <1500627551-12930-1-git-send-email-bhe@redhat.com> <1500627551-12930-7-git-send-email-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1500627551-12930-7-git-send-email-bhe@redhat.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 609 Lines: 19 On Fri, Jul 21, 2017 at 04:59:04PM +0800, Baoquan He wrote: > @@ -2128,9 +2131,43 @@ static void early_enable_iommu(struct amd_iommu *iommu) > static void early_enable_iommus(void) > { > struct amd_iommu *iommu; > + bool is_pre_enabled = false; > > - for_each_iommu(iommu) > - early_enable_iommu(iommu); > + for_each_iommu(iommu) { > + if (translation_pre_enabled(iommu)) { > + is_pre_enabled = true; > + break; > + } > + } is_pre_enabled should only be true when _all_ iommus are pre-enabled. If only one is found disabled just disable the others and continue without copying the device table.