Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751517AbdG0PoM (ORCPT ); Thu, 27 Jul 2017 11:44:12 -0400 Received: from mx2.suse.de ([195.135.220.15]:42495 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750981AbdG0PoL (ORCPT ); Thu, 27 Jul 2017 11:44:11 -0400 Subject: Re: [PATCH] xen: cleanup xen.h To: Boris Ostrovsky , linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org References: <20170727151158.1739-1-jgross@suse.com> <95b842f3-aa02-ac05-6153-8f6a989fce15@oracle.com> From: Juergen Gross Message-ID: Date: Thu, 27 Jul 2017 17:44:08 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <95b842f3-aa02-ac05-6153-8f6a989fce15@oracle.com> Content-Type: text/plain; charset=windows-1252 Content-Language: de-DE Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1108 Lines: 37 On 27/07/17 17:37, Boris Ostrovsky wrote: > On 07/27/2017 11:11 AM, Juergen Gross wrote: >> The macros for testing domain types are more complicated then they >> need to. Simplify them. >> >> Signed-off-by: Juergen Gross >> --- >> include/xen/xen.h | 20 +++++++++----------- >> 1 file changed, 9 insertions(+), 11 deletions(-) >> >> diff --git a/include/xen/xen.h b/include/xen/xen.h >> index 6e8b7fc79801..28c59ca529d7 100644 >> --- a/include/xen/xen.h >> +++ b/include/xen/xen.h >> @@ -13,11 +13,16 @@ extern enum xen_domain_type xen_domain_type; >> #define xen_domain_type XEN_NATIVE >> #endif >> >> +#ifdef CONFIG_XEN_PVH >> +extern bool xen_pvh; >> +#else >> +#define xen_pvh 0 >> +#endif >> + >> #define xen_domain() (xen_domain_type != XEN_NATIVE) >> -#define xen_pv_domain() (xen_domain() && \ >> - xen_domain_type == XEN_PV_DOMAIN) >> -#define xen_hvm_domain() (xen_domain() && \ >> - xen_domain_type == XEN_HVM_DOMAIN) >> +#define xen_pv_domain() (xen_domain_type == XEN_PV_DOMAIN) > > Stray tab. No. This is just due to the '+' of the patch. Juergen