Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751577AbdG0Psq (ORCPT ); Thu, 27 Jul 2017 11:48:46 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:34565 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750836AbdG0Pso (ORCPT ); Thu, 27 Jul 2017 11:48:44 -0400 Subject: Re: [PATCH 1/3] memory: mtk-smi: add larbid init routine To: honghui.zhang@mediatek.com, joro@8bytes.org, robh@kernel.org, robin.murphy@arm.com Cc: devicetree@vger.kernel.org, kendrick.hsu@mediatek.com, srv_heupstream@mediatek.com, will.deacon@arm.com, linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, robh+dt@kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, youlin.pei@mediatek.com, erin.lo@mediatek.com, yong.wu@mediatek.com, xinping.qian@mediatek.com References: <1501120872-19652-1-git-send-email-honghui.zhang@mediatek.com> <1501120872-19652-2-git-send-email-honghui.zhang@mediatek.com> From: Matthias Brugger Message-ID: Date: Thu, 27 Jul 2017 17:42:29 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <1501120872-19652-2-git-send-email-honghui.zhang@mediatek.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1778 Lines: 53 On 07/27/2017 04:01 AM, honghui.zhang@mediatek.com wrote: > From: Honghui Zhang > > In the commit 3c8f4ad85c4b ("memory/mediatek: add support for mt2701"), > the larb->larbid was added but not initialized. > Mediatek's gen1 smi need this hardware larbid information to get the > register offset which controls whether enable iommu for this larb. > This patch add the initialize routine for larbid. > > Signed-off-by: Honghui Zhang > --- > drivers/memory/mtk-smi.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/drivers/memory/mtk-smi.c b/drivers/memory/mtk-smi.c > index 2b798bb4..fe36b3e 100644 > --- a/drivers/memory/mtk-smi.c > +++ b/drivers/memory/mtk-smi.c > @@ -240,6 +240,7 @@ static int mtk_smi_larb_probe(struct platform_device *pdev) > struct device *dev = &pdev->dev; > struct device_node *smi_node; > struct platform_device *smi_pdev; > + int err; > > if (!dev->pm_domain) > return -EPROBE_DEFER; > @@ -263,6 +264,14 @@ static int mtk_smi_larb_probe(struct platform_device *pdev) > return PTR_ERR(larb->smi.clk_smi); > larb->smi.dev = dev; > > + err = of_property_read_u32(dev->of_node, "mediatek,larbid", > + &larb->larbid); > + if (err && of_device_is_compatible(dev->of_node, > + "mediatek,mt2701-smi-larb")) { Instead of checking hard-coded bindings you should be able to determine the generation using the smi_pdev. Apart I think it would be better to check for mediatek,larbid only on MTK_SIM_GEN1, or do I miss something? Regards, Matthias > + dev_err(dev, "missing larbid property\n"); > + return err; > + } > + > smi_node = of_parse_phandle(dev->of_node, "mediatek,smi", 0); > if (!smi_node) > return -EINVAL; >