Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751667AbdG0P57 (ORCPT ); Thu, 27 Jul 2017 11:57:59 -0400 Received: from mx2.suse.de ([195.135.220.15]:43900 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751547AbdG0P56 (ORCPT ); Thu, 27 Jul 2017 11:57:58 -0400 Date: Thu, 27 Jul 2017 17:57:55 +0200 From: Joerg Roedel To: Baoquan He Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v8 11/13] iommu/amd: Don't copy GCR3 table root pointer Message-ID: <20170727155755.GP3610@suse.de> References: <1500627551-12930-1-git-send-email-bhe@redhat.com> <1500627551-12930-12-git-send-email-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1500627551-12930-12-git-send-email-bhe@redhat.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 586 Lines: 10 On Fri, Jul 21, 2017 at 04:59:09PM +0800, Baoquan He wrote: > When iommu is pre_enabled in kdump kernel, if a device is set up with > guest translations (DTE.GV=1), then don't copy GCR3 table root pointer > but move the device over to an empty guest-cr3 table and handle the > faults in the PPR log (which answer them with INVALID). After all these > PPR faults are recoverable for the device and we should not allow the > device to change old-kernels data when we don't have to. Okay, forget my previous comment about disabling IOMMUv2 features while copying. Its done in this patch.