Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751653AbdG0P64 (ORCPT ); Thu, 27 Jul 2017 11:58:56 -0400 Received: from mx2.suse.de ([195.135.220.15]:44004 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751030AbdG0P6z (ORCPT ); Thu, 27 Jul 2017 11:58:55 -0400 Date: Thu, 27 Jul 2017 17:58:52 +0200 From: Joerg Roedel To: Baoquan He Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, root Subject: Re: [PATCH v8 13/13] iommu/amd: Disable iommu only if amd_iommu=off is specified Message-ID: <20170727155852.GQ3610@suse.de> References: <1500627551-12930-1-git-send-email-bhe@redhat.com> <1500627551-12930-14-git-send-email-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1500627551-12930-14-git-send-email-bhe@redhat.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 973 Lines: 31 On Fri, Jul 21, 2017 at 04:59:11PM +0800, Baoquan He wrote: > From: root You probaly need to reset the author on this one. > > It's ok to disable iommu in normal kernel. While there's no need > to disable it in kdump kernel after the on-flight dma issue has > heen fixed. > > Signed-off-by: Baoquan He > --- > drivers/iommu/amd_iommu_init.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/iommu/amd_iommu_init.c b/drivers/iommu/amd_iommu_init.c > index 8b4bac978062..880f693c809b 100644 > --- a/drivers/iommu/amd_iommu_init.c > +++ b/drivers/iommu/amd_iommu_init.c > @@ -2494,7 +2494,8 @@ static int __init early_amd_iommu_init(void) > goto out; > > /* Disable any previously enabled IOMMUs */ > - disable_iommus(); > + if (amd_iommu_disabled) > + disable_iommus(); > > if (amd_iommu_irq_remap) > amd_iommu_irq_remap = check_ioapic_information(); > -- > 2.5.5